Test: Replace NewClient() with NewClientT()#38417
Merged
yongtang merged 1 commit intomoby:masterfrom Jan 5, 2019
Merged
Conversation
thaJeztah
commented
Dec 22, 2018
Member
Author
There was a problem hiding this comment.
Ah, hmm.... got it.. that won't work
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
replace_newclient
branch
from
648a826 to
2cb7b73
Compare
Contributor
|
@thaJeztah looks to be some issue on z ? |
Member
Author
|
Hm, yeah, let me try and restart, but could be an issue with those machines 🤔 |
Codecov Report
@@ Coverage Diff @@
## master #38417 +/- ##
==========================================
+ Coverage 36.54% 36.55% +<.01%
==========================================
Files 608 608
Lines 45036 45036
==========================================
+ Hits 16460 16461 +1
+ Misses 26295 26293 -2
- Partials 2281 2282 +1 |
Member
Author
|
@yongtang @AkihiroSuda PTAL 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @vdemeester PTAL 🤗