integration-cli/build: don't panic ;)#38411
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Dec 21, 2018
Merged
Conversation
Merged
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby#38404. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
dont-panic
branch
from
6663397 to
7e7ff2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #38411 +/- ##
==========================================
+ Coverage 36.58% 36.58% +<.01%
==========================================
Files 608 608
Lines 44988 44988
==========================================
+ Hits 16458 16460 +2
+ Misses 26250 26249 -1
+ Partials 2280 2279 -1 |
AkihiroSuda
approved these changes
Dec 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lack of check in the test code can lead to a panic due to
len(ids)being0.Avoid the panic by adding appropriate checks. Note
Assert()should beused rather than
Check()as if it fails we should not proceed with thetest.
Originally found in #38404.