Skip to content

Switch Dockerfile.e2e to alpine 3.8#38403

Merged
tiborvass merged 2 commits intomoby:masterfrom
thaJeztah:switch_to_alpine_3.8
Dec 21, 2018
Merged

Switch Dockerfile.e2e to alpine 3.8#38403
tiborvass merged 2 commits intomoby:masterfrom
thaJeztah:switch_to_alpine_3.8

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Follow up to #38402

go1.11.4 (released 2018/12/14) includes fixes to cgo, the compiler, linker,
runtime, documentation, go command, and the net/http and go/types packages. It
includes a fix to a bug introduced in Go 1.11.3 that broke go get for import
path patterns containing "...".

See the Go 1.11.4 milestone for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 21, 2018

Codecov Report

Merging #38403 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #38403      +/-   ##
==========================================
- Coverage   36.59%   36.58%   -0.01%     
==========================================
  Files         608      608              
  Lines       44988    44988              
==========================================
- Hits        16462    16458       -4     
- Misses      26247    26250       +3     
- Partials     2279     2280       +1

@thaJeztah
Copy link
Copy Markdown
Member Author

@tiborvass PTAL The first commit was merged already, so I think it will just dissolve when we merge this one, but I can rebase if you think it's cleaner

@tiborvass tiborvass merged commit ab318fa into moby:master Dec 21, 2018
@thaJeztah thaJeztah deleted the switch_to_alpine_3.8 branch December 21, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants