Switch Dockerfile.e2e to alpine 3.8#38403
Merged
tiborvass merged 2 commits intomoby:masterfrom Dec 21, 2018
Merged
Conversation
go1.11.4 (released 2018/12/14) includes fixes to cgo, the compiler, linker, runtime, documentation, go command, and the net/http and go/types packages. It includes a fix to a bug introduced in Go 1.11.3 that broke go get for import path patterns containing "...". See the Go 1.11.4 milestone for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Merged
Codecov Report
@@ Coverage Diff @@
## master #38403 +/- ##
==========================================
- Coverage 36.59% 36.58% -0.01%
==========================================
Files 608 608
Lines 44988 44988
==========================================
- Hits 16462 16458 -4
- Misses 26247 26250 +3
- Partials 2279 2280 +1 |
Member
Author
|
@tiborvass PTAL The first commit was merged already, so I think it will just dissolve when we merge this one, but I can rebase if you think it's cleaner |
tiborvass
approved these changes
Dec 21, 2018
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #38402