Skip to content

Fix missing import#38360

Merged
cpuguy83 merged 1 commit into
moby:masterfrom
thaJeztah:fix_missing_import
Dec 12, 2018
Merged

Fix missing import#38360
cpuguy83 merged 1 commit into
moby:masterfrom
thaJeztah:fix_missing_import

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Dec 12, 2018

Copy link
Copy Markdown
Member

fixes #38361

This import got lost after commit 56cc56b (#38126) was merged, likely because the PR was built against an outdated master and #38316 was just merged before the PR.

This import got lost after commit 56cc56b
was merged, likely because the PR was built against an outdated
master.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah

Copy link
Copy Markdown
Member Author

ping @vdemeester @tiborvass PTAL

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 🙀
LGTM 🦁

@thaJeztah

Copy link
Copy Markdown
Member Author

haha 💩happens

@thaJeztah

Copy link
Copy Markdown
Member Author

I'll move this to "merge"; when build passes, I think we can just merge this

@cpuguy83 cpuguy83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
cpuguy83 merged commit f711f2b into moby:master Dec 12, 2018
@thaJeztah
thaJeztah deleted the fix_missing_import branch December 12, 2018 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG after merged pull request #38316 from dmandalidis/xattr-fix hack/make.sh binary failes

4 participants