Conversation
The v1.10 layout and the migrator was added in 2015 via moby#17924. Although the migrator is not marked as "deprecated" explicitly in cli/docs/deprecated.md, I suppose people should have already migrated from pre-v1.10 and they no longer need the migrator, because pre-v1.10 version do not support schema2 images (and these versions no longer receives security updates). Signed-off-by: Akihiro Suda <[email protected]>
|
I'm fine with it, but would be good to get @tonistiigi and @andrewhsu to chime in. |
lowenna
left a comment
lowenna
left a comment
There was a problem hiding this comment.
No concerns from the Windows side
Codecov Report
@@ Coverage Diff @@
## master #38265 +/- ##
==========================================
- Coverage 36.08% 35.87% -0.22%
==========================================
Files 610 609 -1
Lines 45236 45244 +8
==========================================
- Hits 16325 16230 -95
- Misses 26669 26823 +154
+ Partials 2242 2191 -51 |
andrewhsu
left a comment
andrewhsu
left a comment
There was a problem hiding this comment.
SGTM w.r.t. removing deadwood code
|
SGTM |
|
Quick chat with @tonistiigi - he's ok with removing this, but wondered if we could produce a decent error message if we run into store that wasn't migrated yet; I'm not sure if there's an easy way to detect that without scanning all directories; if there is, I think that would be a nice follow-up, but if we need to scan all directories, then I think we should leave it as is |
|
Moved this one to "merge", but if you want to make that enhancement in this PR @AkihiroSuda, let me know, otherwise feel free to push the merge button 👍 |
This is an additon to commit 1fea388 ("Remove v1.10 migrator") aka PR moby#38265. Since that one, CreateRWLayerByGraphID() is not used anywhere, so let's drop it. Signed-off-by: Kir Kolyshkin <[email protected]>
This is an additon to commit 1fea388 ("Remove v1.10 migrator") aka PR moby#38265. Since that one, CreateRWLayerByGraphID() is not used anywhere, so let's drop it. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit b4e9b50) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This is an additon to commit 1fea388 ("Remove v1.10 migrator") aka PR moby#38265. Since that one, CreateRWLayerByGraphID() is not used anywhere, so let's drop it. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit b4e9b50) Signed-off-by: Sebastiaan van Stijn <[email protected]>
8 participants
The v1.10 layout and the migrator was added in 2015 via #17924.
Although the migrator is not marked as "deprecated" explicitly in
cli/docs/deprecated.md, I suppose people should have already migratedfrom pre-v1.10 and they no longer need the migrator, because pre-v1.10
version do not support schema2 images (and these versions no longer
receives security updates).
Signed-off-by: Akihiro Suda [email protected]