Skip to content

Deprecate legacy overlay storage driver, and add warning#38018

Merged
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:add_overlay_deprecation_warning
Oct 12, 2018
Merged

Deprecate legacy overlay storage driver, and add warning#38018
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:add_overlay_deprecation_warning

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 11, 2018

Related deprecation note PR: docker/cli#1425

This PR is built on top of #38017, but I can rebase once that's merged

The overlay storage driver is deprecated in favor of the overlay2 storage
driver, which has all the benefits of overlay, without its limitations (excessive
inode consumption). The legacy overlay storage driver will be removed in a future
release. Users of the overlay storage driver should migrate to the overlay2
storage driver.

The legacy overlay storage driver allowed using overlayFS-backed filesystems
on pre 4.x kernels. Now that all supported distributions are able to run overlay2
(as they are either on kernel 4.x, or have support for multiple lowerdirs
backported), there is no reason to keep maintaining the overlay storage driver.

@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 11, 2018

ping @dmcgowan @AkihiroSuda @andrewhsu PTAL

@thaJeztah thaJeztah mentioned this pull request Oct 11, 2018
Merged
vdemeester
vdemeester approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah
Deprecate "devicemapper" storage driver, and add warning
06fcabb 
The `devicemapper` storage driver is deprecated in favor of `overlay2`, and will
be removed in a future release. Users of the `devicemapper` storage driver are
recommended to migrate to a different storage driver, such as `overlay2`, which
is now the default storage driver.

The `devicemapper` storage driver facilitates running Docker on older (3.x) kernels
that have no support for other storage drivers (such as overlay2, or AUFS).

Now that support for `overlay2` is added to all supported distros (as they are
either on kernel 4.x, or have support for multiple lowerdirs backported), there
is no reason to continue maintenance of the `devicemapper` storage driver.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Deprecate legacy overlay storage driver, and add warning
31be4e0 
The `overlay` storage driver is deprecated in favor of the `overlay2` storage
driver, which has all the benefits of `overlay`, without its limitations (excessive
inode consumption). The legacy `overlay` storage driver will be removed in a future
release. Users of the `overlay` storage driver should migrate to the `overlay2`
storage driver.

The legacy `overlay` storage driver allowed using overlayFS-backed filesystems
on pre 4.x kernels. Now that all supported distributions are able to run `overlay2`
(as they are either on kernel 4.x, or have support for multiple lowerdirs
backported), there is no reason to keep maintaining the `overlay` storage driver.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the add_overlay_deprecation_warning branch from ea2b65a to 31be4e0 Compare October 11, 2018 13:49
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1f48759). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #38018   +/-   ##
=========================================
  Coverage          ?   36.11%           
=========================================
  Files             ?      610           
  Lines             ?    45175           
  Branches          ?        0           
=========================================
  Hits              ?    16314           
  Misses            ?    26622           
  Partials          ?     2239

@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 11, 2018 •
edited
Loading

Failure on experimental is unrelated; https://jenkins.dockerproject.org/job/Docker-PRs-experimental/42545/console

14:05:21 --- FAIL: TestServiceWithDefaultAddressPoolInit (1.40s)
14:05:21     daemon.go:292: [d10ddb0a6d8e8] waiting for daemon to start
14:05:21     daemon.go:324: [d10ddb0a6d8e8] daemon started
14:05:21     service_test.go:356: TestServiceWithDefaultAddressPoolInit: NetworkInspect: {Name:saanvisthiraTestServiceWithDefaultAddressPoolInit ID:o8usxdxsfreemezt9sdkpaetv Created:2018-10-11 14:05:21.942960801 +0000 UTC Scope:swarm Driver: EnableIPv6:false IPAM:{Driver: Options:map[] Config:[]} Internal:false Attachable:false Ingress:false ConfigFrom:{Network:} ConfigOnly:false Containers:map[] Options:map[] Labels:map[] Peers:[] Services:map[]}
14:05:21     service_test.go:357: assertion failed: expression is false: len(out.IPAM.Config) > 0
14:05:21 FAIL

@thaJeztah thaJeztah merged commit 31c903d into moby:master Oct 12, 2018
@thaJeztah thaJeztah deleted the add_overlay_deprecation_warning branch October 12, 2018 00:23
@thaJeztah thaJeztah mentioned this pull request Oct 12, 2018
Merged
@thaJeztah thaJeztah mentioned this pull request Mar 14, 2022
Merged
@thaJeztah thaJeztah mentioned this pull request May 24, 2022
Merged
2 tasks
@thaJeztah thaJeztah mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/storage/overlay area/storage Image Storage impact/changelog impact/deprecation impact/documentation status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @vdemeester @AkihiroSuda @GordonTheTurtle