Windows: Client: Allow process isolation [RS5+]#38000
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 10, 2018
Merged
Conversation
Signed-off-by: John Howard <[email protected]>
lowenna
changed the title
lowenna
changed the title
Member
Author
|
@taylorb-microsoft - Binary attached for your validation. |
Contributor
|
You made my day! |
thaJeztah
added
platform/windows
status/2-code-review
impact/changelog
and removed
status/0-triage
labels
Member
I assume people don't run Windows client in "production" (as in; to host their containers) 😅, but maybe some do. @jhowardmsft Are there known issues? Do you think a warning should be included in |
thaJeztah
approved these changes
Oct 10, 2018
Codecov Report
@@ Coverage Diff @@
## master #38000 +/- ##
=========================================
Coverage ? 36.11%
=========================================
Files ? 610
Lines ? 45159
Branches ? 0
=========================================
Hits ? 16307
Misses ? 26610
Partials ? 2242 |
This was referenced Oct 11, 2018
You may be surprised, but we use Windows 10 where possible because of the Windows Server licence cost. |
|
Is this change go live? I mean Docker for Windows release, not Windows 10. |
Member
|
@MikhailTymchukDX not yet; it's been merged to the 18.09.1 Docker CE codebase in docker-archive#81, and after that will find its way into the 18.09.1 Docker EE codebase. It will be available once Docker 18.09.1 EE is released |
|
@thaJeztah I tried with the latest master builds from https://master.dockerproject.com/ but process isolation just hangs. Here is what I did: To make sure everything works I did and also That is as expected as I am on 18.09.0 Now i downloaded the latest master builds which seems to update as expected: docker run still works: Process isolation also doesn't show the immediate error, so the PR seems to be merged in that binary but it just hangs here: Daemon output looks like this and then also just hangs Any idea what might go wrong? Am I missing something? I am happy to provide more information if needed but I unfortunately don't know where to start looking |
Member
Author
|
@tfenster Can you open a new issue with this information rather than a comment against the PR. FWIW, I am not able to repro this, and I know many other people who are successfully running process isolated containers on RS5 after this PR. Thanks. |
|
@jhowardmsft I created #38306, thanks for looking at it. Might very well be a problem with my setup, would appreciate any hints where I might start looking |
|
As mentioned in docker/for-win#1822 (comment) and docker/for-win#3571 it seems like Hyper-V and Hardware Virtualization support are still hard requirements for Docker Desktop on Windows 10? I will open up a new issue for that, but I wanted to mention here that I am unable to make process isolation work without Hardware Virtualization support due to the Host Network Service not being able to fulfil networking requests to the Docker daemon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #27524
fixes #37873
fixes docker/for-win#1822
closes #37065
closes #27730
Signed-off-by: John Howard 🇬🇧 [email protected]
A lot of people will like this! As of Windows 10 (i.e. client) version 1809 (aka RS5), we are removing the restriction limiting docker to Hyper-V isolation only. With this fix, when running on RS5/later, client SKUs will be able to add
--isolation=processto run a container with process isolation. Note that the support statement is that we allow it for dev/test, but don't support it for production usage. I'll let @taylorb-microsoft/@scooley and folks on that team figure where this should be documented/announced/marketed, and to make that change as a follow-up. I'm staying well clear of that conversation 😇 😆It also removes the IoTCore check, which was nonsense previously and didn't work. That needs re-evaluation at a later date, if ever (there is a separate workaround currently).
@taylorb-microsoft - Can you do some validation that this operates as you expect and as we discussed?
ping @thaJeztah @simonferquel @johnstep.