Merged
Conversation
|
Please sign your commits following these rules: $ git clone -b "fix_typo" [email protected]:16yuki0702/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
GordonTheTurtle
added
dco/no
GordonTheTurtle
removed
the
dco/no
AkihiroSuda
requested changes
Oct 5, 2018
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Please sign the commit with your real full name
Codecov Report
@@ Coverage Diff @@
## master #37981 +/- ##
=========================================
Coverage ? 36.08%
=========================================
Files ? 610
Lines ? 45143
Branches ? 0
=========================================
Hits ? 16292
Misses ? 26612
Partials ? 2239 |
Signed-off-by: Hiroyuki Sasagawa <[email protected]>
Contributor
Author
|
@AkihiroSuda I'm sorry. I re-signed the commit with my full name. |
AkihiroSuda
approved these changes
Oct 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think It's a little typo.