TestSwarmContainerEndpointOptions: fix debug#37958
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 4, 2018
Merged
Conversation
In case of failure, stale out was printed. Fixes: 6212ea6 Signed-off-by: Kir Kolyshkin <[email protected]>
thaJeztah
approved these changes
Oct 3, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
we should cherry-pick this into the docker/engine 18.09 branch as well
Member
|
Relates to #29663 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of failure, stale out was printed.
Fixes: 6212ea6
Found during analysis of test failure like the following:
01:28:49.436
01:28:49.436 ----------------------------------------------------------------------
01:28:49.436 FAIL: docker_cli_swarm_test.go:340: DockerSwarmSuite.TestSwarmContainerEndpointOptions
01:28:49.436
01:28:49.436 [d9936cbb33a13] waiting for daemon to start
01:28:49.436 [d9936cbb33a13] daemon started
01:28:49.436
01:28:49.436 docker_cli_swarm_test.go:348:
01:28:49.436 c.Assert(err, checker.IsNil, check.Commentf("%s", out))
01:28:49.436 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc0008da200), Stderr:[]uint8(nil)} ("exit status 125")
01:28:49.437 ... enp0ai1ixwecue5w696pgzggp
01:28:49.437
01:28:49.437
01:28:49.437 [d9936cbb33a13] exiting daemon
01:28:52.285
01:28:52.285 ----------------------------------------------------------------------
(the above is from https://jenkins.dockerproject.org/job/Docker-PRs-s390x/11487/console, which comes from #37833, but it's not unique).