Skip to content

migrated ipc integration tests to integration/container#37851

Merged
yongtang merged 1 commit intomoby:masterfrom
adshmh:migrate-ipc-integration-tests-to-integration-container
Sep 22, 2018
Merged

migrated ipc integration tests to integration/container#37851
yongtang merged 1 commit intomoby:masterfrom
adshmh:migrate-ipc-integration-tests-to-integration-container

Conversation

@adshmh
Copy link
Contributor

@adshmh adshmh commented Sep 14, 2018

- What I did
Migrated IPC integration tests from integration-cli to integration/container package.

- How I did it
Added the modified integration tests to integration/container/ipc_mode_test.go

- How to verify it

- Description for the changelog
IPC integration tests migrated from integration-cli to integration/container

- A picture of a cute animal (not mandatory but encouraged)

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9299561). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37851   +/-   ##
=========================================
  Coverage          ?   36.13%           
=========================================
  Files             ?      610           
  Lines             ?    45085           
  Branches          ?        0           
=========================================
  Hits              ?    16291           
  Misses            ?    26556           
  Partials          ?     2238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants