TestServiceWithDefaultAddressPoolInit#37836
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 15, 2019
Merged
Conversation
Member
|
ping @kolyshkin |
Contributor
|
@selansen once you have a failure, take a look at the relevant daemon.log, maybe there's some hints in there. I have a couple of other test cases involving swarm that fail randomly, and it's only happening in CI and never locally, such as #37833. I figured out the code flow, scrutinized the source code, but still don't have a clue about what is going on :( |
Member
|
What's current status? |
Closed
Contributor
|
@selansen this one needs to be rebased |
derek
bot
added
the
status/failing-ci
Looks like TestServiceWithDefaultAddressPoolInit is failing randomly in CI. I am not able to reproduce the issue locally but this has been reported few times. So I tried to modify code and see if I can fix the random failure. Signed-off-by: selansen <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
removed
the
status/failing-ci
Codecov Report
@@ Coverage Diff @@
## master #37836 +/- ##
=========================================
Coverage ? 37.31%
=========================================
Files ? 609
Lines ? 45232
Branches ? 0
=========================================
Hits ? 16877
Misses ? 26065
Partials ? 2290 |
Member
|
rebased |
thaJeztah
approved these changes
Jul 15, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
not sure if this fixes the flakiness, but changes don't look like they'll harm, so bringing this in
This was referenced Sep 21, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: selansen [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)