Skip to content

TestStartReturnCorrectExitCode: show error#37820

Merged
tiborvass merged 1 commit intomoby:masterfrom
kolyshkin:TestStartReturnCorrectExitCode
Sep 12, 2018
Merged

TestStartReturnCorrectExitCode: show error#37820
tiborvass merged 1 commit intomoby:masterfrom
kolyshkin:TestStartReturnCorrectExitCode

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Sep 10, 2018

Seen this error:

00:54:01.860 
00:54:01.860 ----------------------------------------------------------------------
00:54:01.860 FAIL: docker_cli_start_test.go:189: DockerSuite.TestStartReturnCorrectExitCode
00:54:01.860 
00:54:01.860 docker_cli_start_test.go:198:
00:54:01.860     c.Assert(exitCode, checker.Equals, 12)
00:54:01.861 ... obtained int = 125
00:54:01.861 ... expected int = 12
00:54:01.861 
00:54:01.861 
00:54:01.861 ----------------------------------------------------------------------

Apparently there's something going on with docker start, and it would be good to know what.

@kolyshkin
Copy link
Contributor Author

kolyshkin commented Sep 10, 2018

Error is from here, found while running CI for #37805

@kolyshkin kolyshkin force-pushed the TestStartReturnCorrectExitCode branch from 3f803f5 to 4cec355 Compare September 11, 2018 17:20
@codecov
Copy link

codecov bot commented Sep 11, 2018 •
edited
Loading

Codecov Report

Merging #37820 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #37820      +/-   ##
==========================================
- Coverage   36.15%   36.14%   -0.02%     
==========================================
  Files         610      610              
  Lines       45054    45054              
==========================================
- Hits        16288    16283       -5     
- Misses      26527    26530       +3     
- Partials     2239     2241       +2

@kolyshkin kolyshkin force-pushed the TestStartReturnCorrectExitCode branch from 4cec355 to 0d59f43 Compare September 11, 2018 19:48
@kolyshkin kolyshkin mentioned this pull request Sep 11, 2018
Merged
vdemeester
vdemeester approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

andrewhsu
andrewhsu approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiborvass
tiborvass approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiborvass tiborvass merged commit d6ac319 into moby:master Sep 12, 2018
@thaJeztah thaJeztah mentioned this pull request Oct 3, 2018
Closed
@thaJeztah thaJeztah mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiborvass tiborvass tiborvass approved these changes

+2 more reviewers

@vdemeester vdemeester vdemeester approved these changes

@andrewhsu andrewhsu andrewhsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kolyshkin @vdemeester @andrewhsu @tiborvass @GordonTheTurtle