Merged
Conversation
|
Please sign your commits following these rules: $ git clone -b "fix-typo-changelog" [email protected]:tossmilestone/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
cb3c4e9 to
ba39aa3
Compare
Codecov Report
@@ Coverage Diff @@
## master #37783 +/- ##
=========================================
Coverage ? 36.03%
=========================================
Files ? 610
Lines ? 45070
Branches ? 0
=========================================
Hits ? 16243
Misses ? 26597
Partials ? 2230 |
AkihiroSuda
reviewed
Sep 7, 2018
155f768 to
9b06261
Compare
Member
|
Please squash the commits to a single commit. Also, it would be appreciated if you could collaborate your colleagues to squash all the typo-fix PRs as well. |
Signed-off-by: Xiaoxi He <[email protected]>
9b06261 to
5c0d2a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various spell errors