Skip to content

Fix various spell errors#37783

Merged
thaJeztah merged 1 commit intomoby:masterfrom
tossmilestone:fix-typo-changelog
Sep 7, 2018
Merged

Fix various spell errors#37783
thaJeztah merged 1 commit intomoby:masterfrom
tossmilestone:fix-typo-changelog

Conversation

@tossmilestone
Copy link
Contributor

@tossmilestone tossmilestone commented Sep 7, 2018

Fix various spell errors

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix-typo-changelog" [email protected]:tossmilestone/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@GordonTheTurtle GordonTheTurtle added dco/no Automatically set by a bot when one of the commits lacks proper signature status/0-triage labels Sep 7, 2018
@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Sep 7, 2018
@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@54b62e6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37783   +/-   ##
=========================================
  Coverage          ?   36.03%           
=========================================
  Files             ?      610           
  Lines             ?    45070           
  Branches          ?        0           
=========================================
  Hits              ?    16243           
  Misses            ?    26597           
  Partials          ?     2230

@tossmilestone tossmilestone changed the title Fix spell error of 'unnecessary' Fix various spell errors Sep 7, 2018
@AkihiroSuda
Copy link
Member

Please squash the commits to a single commit.

Also, it would be appreciated if you could collaborate your colleagues to squash all the typo-fix PRs as well.

Signed-off-by: Xiaoxi He <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants