integration-cli: fix TestAttachDetach, rm TestAttachDetachTruncatedID#37718
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 27, 2018
Merged
integration-cli: fix TestAttachDetach, rm TestAttachDetachTruncatedID#37718thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
It looks like the logic of the test became wrong after commit ae0883c ("Move TestAttachDetach to integration-cli"). The original logic was: * (a few first steps skipped for clarity) * send escape sequence to "attach"; * check "attach" is exiting (i.e. escape sequence works); * check the container is still alive; * kill the container. Also, timeouts were big at that time, in the order of seconds. The logic after the above mentioned commit and until now is: * ... * send escape sequence to "attach"; * check the container is running (why shouldn't it?); * kill the container; * checks that the "attach" has exited. So, from the "let's check detach using escape sequence is working" the test became something like "let's check that attach is gone once we kill the container". Let's fix the above test, also increasing the timeout waiting for attach to exit (which fails from time to time on power CI). Now, the second test, TestAttachDetachTruncatedID, does the exact same thing, except it uses a truncated container ID. It does not seem to be of much value, so let's remove it. Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
|
@arm64b PTAL |
Codecov Report
@@ Coverage Diff @@
## master #37718 +/- ##
=========================================
Coverage ? 36.04%
=========================================
Files ? 609
Lines ? 45063
Branches ? 0
=========================================
Hits ? 16242
Misses ? 26592
Partials ? 2229 |
This was referenced Aug 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(this is a continuation of #37711)
It looks like the logic of the test became wrong after commit ae0883c (PR #12292).
The original logic was:
Also, timeouts were big at that time, in the order of seconds.
The logic after the above mentioned commit and until now is:
So, from the "let's check detach using escape sequence is working"
the test became something like "let's check that attach is gone
once we kill the container".
Let's fix the above test, also increasing the timeout waiting
for attach to exit (which fails from time to time on power CI).
Now, the second test, TestAttachDetachTruncatedID, does the exact
same thing, except it uses a truncated container ID. It does not
seem to be of much value, so let's remove it.