Looks like build is failing

Codecov Report

❗ No coverage uploaded for pull request base (master@87e7930). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37715   +/-   ##
=========================================
  Coverage          ?    36.3%           
=========================================
  Files             ?      610           
  Lines             ?    45644           
  Branches          ?        0           
=========================================
  Hits              ?    16572           
  Misses            ?    26802           
  Partials          ?     2270

cc @psftw too. This has knock on effect on CE/EE jobs too on the other Jenkins system.

OK, have verified it doesn't break Invoke-Docker-CI. However, note that none of the integration tests are actually run with this PR, just the integration-cli tests. I would sign-off once the rename is done (and I'll need to update the Jenkins job to match). There's certainly some tidying to do in the CI script as put in this PR (arguably, it doesn't actually need to be in this PR as it's completely unrelated), as well as an update to Invoke-DockerCI to use the checked in script, and also removing the CI script from it's current master source of truth under my GH repo.

@jhowardmsft Thanks for verifying. I have done the renaming of windowsRS1.ps1 to windows.ps1 as requested. Note that the failure in the janky run below is due to a known flaky test in networking.

Have updated the Jenkins job at https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/configure (you may not have access) to point to windows.ps1 and restarted the job to re-verify again, and ensure the console output contains NEW entrypoint.

Specifically

Old:

if (Test-Path hack\ci\windowsRS1.ps1) {
    Write-Host "NEW entrypoint"
    .\hack\ci\windowsRS1.ps1
    exit $LastExitCode
}

New:

if (Test-Path hack\ci\windows.ps1) {
    Write-Host "NEW entrypoint"
    .\hack\ci\windows.ps1
    exit $LastExitCode
}

Once this is merged, that Write-Host can be removed, along with the rest of the script embedded in the job. I'll also update the RS5 jobs.

@psftw - Have you managed to look at the follow-on impact to other CE/EE jobs?

LGTM. But I'm concerned about the impact to CE/EE jobs still which I don't have access to.

Have verified is running the in-repo script now after reconfiguring jenkins Docker-PRs-WOW-RS1 job. From
https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/22555/console:

00:00:58.114 [docker] $ powershell.exe -NonInteractive -ExecutionPolicy ByPass "& 'C:\Users\jenkins\jenkins2734567844840291984.ps1'"
00:00:58.495 NEW entrypoint
00:00:58.594 

I synced up with @jhowardmsft offline about his concern around internal CI jobs. The plan is to start syncing up the enhancements made for them (RS3/4/5) into windows.ps1 once the above PR gets merged.