remove experimental guard for buildkit#37686
Merged
tiborvass merged 2 commits intomoby:masterfrom Aug 21, 2018
andrewhsu:bk-no-ex
Merged
remove experimental guard for buildkit#37686tiborvass merged 2 commits intomoby:masterfrom andrewhsu:bk-no-ex
tiborvass merged 2 commits intomoby:masterfrom
andrewhsu:bk-no-ex
Conversation
Signed-off-by: Andrew Hsu <[email protected]>
thaJeztah
added
area/builder
thaJeztah
approved these changes
Aug 21, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
twiddle-dee-twiddle-dom
tiborvass
requested changes
Aug 21, 2018
Contributor
tiborvass
left a comment
tiborvass
left a comment
There was a problem hiding this comment.
experimentalProvider could be removed in a followup.
But since buildkit relies on /session endpoint, that would also need to graduate out of experimental (remove router.Experimental in api/router/session)
Signed-off-by: Andrew Hsu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #37686 +/- ##
=========================================
Coverage ? 36.04%
=========================================
Files ? 609
Lines ? 45041
Branches ? 0
=========================================
Hits ? 16235
Misses ? 26575
Partials ? 2231 |
Contributor
|
@tiborvass I think Andrew has updated the PR. Can we get this one in first to avoid conflicts? |
This was referenced Oct 2, 2019
[18.09 backport] API: update docs that /session left experimental in V1.39
docker-archive/engine#390
Merged
Member
|
Looks like I forgot to follow-up on this one to update the docs; so, with some delay: #40028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Allow buildkit builds to run without experimental mode enabled. Buildkit can now be twiddled with a specific flag #37593
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
🐈