Add osusergo build tar for static binaries#37500
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 19, 2018
Merged
Conversation
Merged
thaJeztah
approved these changes
Jul 19, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
one nit, but LGTM after that's been addressed
hack/make.sh
Outdated
Member
There was a problem hiding this comment.
can you make this sorted alphabetically?
Go 1.11 includes a fix to os/user to be working in a static binary (fixing golang/go#23265). The fix requires `osusergo` build tag to be set for static binaries, which is what this commit adds (also for containerd). [v2: sort build tags alphabetically] Signed-off-by: Kir Kolyshkin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #37500 +/- ##
=========================================
Coverage ? 34.95%
=========================================
Files ? 610
Lines ? 44886
Branches ? 0
=========================================
Hits ? 15690
Misses ? 27077
Partials ? 2119 |
Contributor
Author
|
Obviously, it does nothing for Go < 1.11. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.11 includes a fix to os/user to be working in a static binary
(fixing golang/go#23265). The fix requires
osusergobuild tag to be set for static binaries, which is whatthis commit adds (also for containerd).
See also: containerd/containerd#2476