fix the race condition in the integration test TestRunContainerWithBridgeNone#37438
Merged
vdemeester merged 1 commit intomoby:masterfrom Aug 1, 2018
Merged
Conversation
…BridgeNone Signed-off-by: Arash Deshmeh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #37438 +/- ##
==========================================
- Coverage 34.96% 34.92% -0.04%
==========================================
Files 610 610
Lines 44886 44870 -16
==========================================
- Hits 15693 15671 -22
- Misses 27075 27078 +3
- Partials 2118 2121 +3 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
This is an attempt at fixing the race condition in the integration test
TestRunContainerWithBridgeNone, pointed out here: #37246 (comment). closes #37246- How I did it
integration/networkin the meantime.- How to verify it
Running the integration test
TestRunContainerWithBridgeNoneshould provide consistent results, as it does not contain a race condition anymore.- Description for the changelog
Fixed the flaky test TestRunContainerWithBridgeNone
- A picture of a cute animal (not mandatory but encouraged)