Skip to content

Comments

bump libnetwork to 3931ba4d815e385ab97093c64477b82f14dadefb#37209

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_libnetwork
Jun 6, 2018
Merged

bump libnetwork to 3931ba4d815e385ab97093c64477b82f14dadefb#37209
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_libnetwork

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 5, 2018

full diff: moby/libnetwork@eb6b2a5...3931ba4

Relevant changes:

Also fixes some typos (moby/libnetwork#2159, moby/libnetwork#2164, moby/libnetwork#2167)

@thaJeztah
Copy link
Member Author

thaJeztah commented Jun 5, 2018

ping @fcrisciani @ctelfer @abhi PTAL

@fcrisciani
Copy link
Contributor

fcrisciani commented Jun 5, 2018

LGTM

vdemeester
vdemeester approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐅

@thaJeztah thaJeztah requested a review from tianon as a code owner June 5, 2018 18:30
@codecov
Copy link

codecov bot commented Jun 5, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ca25df3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37209   +/-   ##
=========================================
  Coverage          ?   34.66%           
=========================================
  Files             ?      609           
  Lines             ?    44973           
  Branches          ?        0           
=========================================
  Hits              ?    15588           
  Misses            ?    27299           
  Partials          ?     2086

@thaJeztah
Copy link
Member Author

thaJeztah commented Jun 6, 2018

Failing tests on experimental (https://jenkins.dockerproject.org/job/Docker-PRs-experimental/40943/console) are known to be flaky: tracked through #36501

01:28:51 FAIL: docker_api_swarm_service_test.go:33: DockerSwarmSuite.TestAPIServiceUpdatePort
01:28:51 
01:28:51 [df69f6d70911e] waiting for daemon to start
01:28:51 [df69f6d70911e] daemon started
01:28:51 
01:28:51 docker_api_swarm_service_test.go:39:
01:28:51     waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1)
01:28:51 docker_utils_test.go:435:
01:28:51     c.Assert(v, checker, args...)
01:28:51 ... obtained int = 0
01:28:51 ... expected int = 1
01:28:51 
01:28:51 [df69f6d70911e] exiting daemon

01:53:04 FAIL: docker_cli_swarm_test.go:1605: DockerSwarmSuite.TestSwarmPublishDuplicatePorts
01:53:04 
01:53:04 [d7290458e3b3e] waiting for daemon to start
01:53:04 [d7290458e3b3e] daemon started
01:53:04 
01:53:04 docker_cli_swarm_test.go:1613:
01:53:04     // make sure task has been deployed.
01:53:04     waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1)
01:53:04 docker_utils_test.go:435:
01:53:04     c.Assert(v, checker, args...)
01:53:04 ... obtained int = 0
01:53:04 ... expected int = 1
01:53:04 
01:53:04 [d7290458e3b3e] exiting daemon

@thaJeztah thaJeztah merged commit 21291e5 into moby:master Jun 6, 2018
@thaJeztah thaJeztah deleted the bump_libnetwork branch June 6, 2018 20:41
@thaJeztah thaJeztah mentioned this pull request Jun 28, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon Awaiting requested review from tianon tianon is a code owner

1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/networking Networking status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Predictive interface order / default gateway

4 participants

@thaJeztah @fcrisciani @vdemeester @GordonTheTurtle