Add support for init on services#37183
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 8, 2018
Merged
Conversation
4 tasks
thaJeztah
reviewed
May 31, 2018
Member
There was a problem hiding this comment.
Ah, yes, ran into this one as well 😄
Member
|
Just so that I don't forget (haven't checked yet);
|
vdemeester
force-pushed
the
service-create-init
branch
from
8178e57 to
52d3c47
Compare
Codecov Report
@@ Coverage Diff @@
## master #37183 +/- ##
=========================================
Coverage ? 34.71%
=========================================
Files ? 609
Lines ? 45001
Branches ? 0
=========================================
Hits ? 15622
Misses ? 27296
Partials ? 2083 |
Member
Author
|
Updated with a test 👼 |
vdemeester
force-pushed
the
service-create-init
branch
4 times, most recently
from
afa65f8 to
c213698
Compare
It's already supported by `swarmkit`, and act the same as `HostConfig.Init` on container creation. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
service-create-init
branch
from
c213698 to
e401b88
Compare
Member
|
Janky failing on a flaky test; #37132 |
tiborvass
reviewed
Jun 7, 2018
| - "process" | ||
| - "hyperv" | ||
| Init: | ||
| description: "Run an init inside the container that forwards signals and reaps processes. This field is omitted if empty, and the default (as configured on the daemon) is used." |
Contributor
There was a problem hiding this comment.
correction: an init *process*, can be done in followup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's already supported by
swarmkit, and act the same asHostConfig.Initon container creation.Depends on moby/swarmkit#2652Depends on #37059Required for docker/cli#479
Signed-off-by: Vincent Demeester [email protected]