Skip to content

Be explicit about github.com prefix being a legacy feature#37174

Merged
vdemeester merged 1 commit into
moby:masterfrom
thaJeztah:no_additional_magic_matching
May 31, 2018
Merged

Be explicit about github.com prefix being a legacy feature#37174
vdemeester merged 1 commit into
moby:masterfrom
thaJeztah:no_additional_magic_matching

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

relates to #37173 and #30412

@thaJeztah
Copy link
Copy Markdown
Member Author

ping @AkihiroSuda @vdemeester

Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@thaJeztah
Copy link
Copy Markdown
Member Author

Flaky test on experimental

FAIL: docker_api_swarm_test.go:296: DockerSwarmSuite.TestAPISwarmLeaderElection
02:01:40 
02:01:40 [dd363de2111e3] waiting for daemon to start
02:01:40 [dd363de2111e3] daemon started
02:01:40 
02:01:40 [d00ce333c1554] waiting for daemon to start
02:01:40 [d00ce333c1554] daemon started
02:01:40 
02:01:40 [d921d05690125] waiting for daemon to start
02:01:40 [d921d05690125] daemon started
02:01:40 
02:01:40 [dd363de2111e3] exiting daemon
02:01:40 assertion failed: error is not nil: Error response from daemon: rpc error: code = DeadlineExceeded desc = context deadline exceeded
02:01:40 [d00ce333c1554] exiting daemon
02:01:40 [d921d05690125] exiting daemon
02:02:04 

@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented May 31, 2018

06:59:24 ----------------------------------------------------------------------
06:59:24 FAIL: docker_cli_swarm_test.go:1372: DockerSwarmSuite.TestSwarmClusterRotateUnlockKey
06:59:24 
06:59:24 [d899e9aa94e6a] waiting for daemon to start
06:59:24 [d899e9aa94e6a] daemon started
06:59:24 
06:59:24 [d902137f3d3f3] waiting for daemon to start
06:59:24 [d902137f3d3f3] daemon started
06:59:24 
06:59:24 [d8b9397006632] waiting for daemon to start
06:59:24 [d8b9397006632] daemon started
06:59:24 
06:59:24 [d902137f3d3f3] exiting daemon
06:59:24 [d902137f3d3f3] waiting for daemon to start
06:59:24 [d902137f3d3f3] daemon started
06:59:24 
06:59:24 [d8b9397006632] exiting daemon
06:59:24 [d8b9397006632] waiting for daemon to start
06:59:24 [d8b9397006632] daemon started
06:59:24 
06:59:24 [d8b9397006632] exiting daemon
06:59:24 [d8b9397006632] waiting for daemon to start
06:59:24 [d8b9397006632] daemon started
06:59:24 
06:59:24 assertion failed: 
06:59:24 Command:  /usr/local/cli/docker --host unix:///tmp/docker-integration/d8b9397006632.sock swarm unlock
06:59:24 ExitCode: 0
06:59:24 Error:    <nil>
06:59:24 Stdout:   
06:59:24 Stderr:   
06:59:24 
06:59:24 Failures:
06:59:24 ExitCode was 0 expected 1
06:59:24 Expected stderr to contain "invalid key"
06:59:24 [d899e9aa94e6a] exiting daemon
06:59:24 [d902137f3d3f3] exiting daemon
06:59:24 [d8b9397006632] exiting daemon
06:59:27 
06:59:27 ----------------------------------------------------------------------

Wonder if its new 😓

@vdemeester vdemeester merged commit 2ea4ece into moby:master May 31, 2018
@thaJeztah thaJeztah deleted the no_additional_magic_matching branch May 31, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants