Make Windows 10 have process isolation only.#37065
Closed
jtilander wants to merge 1 commit intomoby:masterfrom
Closed
Make Windows 10 have process isolation only.#37065jtilander wants to merge 1 commit intomoby:masterfrom
jtilander wants to merge 1 commit intomoby:masterfrom
Conversation
GordonTheTurtle
added
the
dco/no
|
Please sign your commits following these rules: $ git clone -b "feature/process_isolation" [email protected]:jtilander/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Jim Tilander <[email protected]>
jtilander
force-pushed
the
feature/process_isolation
branch
from
942760f to
972d497
Compare
GordonTheTurtle
removed
the
dco/no
Member
|
Sorry, changing this would result in breaking the Windows license. From the code that's being removed in this PR:
I'll close this PR for that reason, but feel free to discuss |
Member
|
This has now been done in #38000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Removed ability to run hyper-v isolation on windows 10.
- How I did it
Delete code to detect windows 10, on non iotc versions.
- How to verify it
Overwrite dockerd.exe on windows 10 and run any docker command, verify in process explorer that you can see the process.
All of this is to raise awareness.