Skip to content

Fix swagger file type for ExecIds#36962

Merged
vdemeester merged 1 commit into
moby:masterfrom
Rid:patch-1
May 22, 2018
Merged

Fix swagger file type for ExecIds#36962
vdemeester merged 1 commit into
moby:masterfrom
Rid:patch-1

Conversation

@Rid
Copy link
Copy Markdown
Contributor

@Rid Rid commented Apr 27, 2018 •
edited by cpuguy83
Loading

This PR fixes #36933

The type for ExecIds in the swagger file was string and not array.

- What I did
Corrected the ExecIds type
- How I did it
Changed "string" to "array"
- How to verify it
Look at the commit :)
- Description for the changelog
Fixed swagger file type for ExecIds

- A picture of a cute animal (not mandatory but encouraged)
e9bb2a136a67b3aa4f28fa89ff2e9e1f-1024x897

@GordonTheTurtle GordonTheTurtle added dco/no Automatically set by a bot when one of the commits lacks proper signature status/0-triage labels Apr 27, 2018
@Rid Rid mentioned this pull request Apr 27, 2018
Closed
@GordonTheTurtle GordonTheTurtle added the dco/no Automatically set by a bot when one of the commits lacks proper signature label Apr 27, 2018
@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label May 15, 2018
thaJeztah
thaJeztah approved these changes May 15, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rebased and squashed commits so that the doc-check passes

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented May 15, 2018

ping @vdemeester PTAL

@Rid @thaJeztah
Fix swagger file type for ExecIds
58a35ea 
Signed-off-by: Grant Millar <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3646562). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36962   +/-   ##
=========================================
  Coverage          ?    35.1%           
=========================================
  Files             ?      615           
  Lines             ?    45821           
  Branches          ?        0           
=========================================
  Hits              ?    16085           
  Misses            ?    27628           
  Partials          ?     2108

@moby moby deleted a comment from GordonTheTurtle May 22, 2018
vdemeester
vdemeester approved these changes May 22, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit 8aa7533 into moby:master May 22, 2018
thaJeztah
thaJeztah reviewed May 22, 2018
View reviewed changes
Comment thread api/swagger.yaml
type: "string"
ExecIDs:
type: "string"
type: "array"
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, just realised this also needs a type for items in the array. Opened a follow-up PR #37121

Copy link
Copy Markdown
Contributor Author

@Rid Rid May 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are also some other issues with the swagger, there's some strings which seem to wrap on to new lines, breaking the YAML.

I can look into those and make another PR when I have some time.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings breaking on new lines should be ok with the right delimiter (but won't work with just quotes indeed)

@Rid Rid mentioned this pull request Sep 15, 2018
Closed
@dontub dontub mentioned this pull request Jun 28, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MHBauer MHBauer

Labels

area/api API status/3-docs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Swagger file has incorrect type for ExecIds

5 participants

@Rid @thaJeztah @vdemeester @GordonTheTurtle @MHBauer