Skip some test on remote daemon for e2e run(s)#36944
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36944 +/- ##
=========================================
Coverage ? 35.39%
=========================================
Files ? 614
Lines ? 45725
Branches ? 0
=========================================
Hits ? 16184
Misses ? 27398
Partials ? 2143 |
|
Some are still missing, will add commits to this PR |
|
Don't merge yet. |
We really need to run those on the CI too at some point. Signed-off-by: Vincent Demeester <[email protected]> Signed-off-by: Tibor Vass <[email protected]>
|
Investigating TestServicePlugin failure... |
|
All CI passed! 🎉 |
|
LGTM |
@tiborvass right, I did that because I wanted to remove the experimental build/check at all at some point 👼 |
| func TestBuildWithSession(t *testing.T) { | ||
| d := daemon.New(t, daemon.WithExperimental) | ||
| d.StartWithBusybox(t) | ||
| defer d.Stop(t) |
There was a problem hiding this comment.
Wasn't this changed recently though, so that we can remove the "experimental" CI, and only have some tests start an experimental daemon
Perhaps we can make this conditional, if we run a local daemon; start an experimental one, otherwise skip if the remote daemon is not experimental
|
Dang; of course forgot to submit my comment - had the same remark as @vdemeester
|
6 participants
We may need to run those on the CI too at some point.
Signed-off-by: Vincent Demeester [email protected]