Bump docker/distribution to 83389a148052d74ac602f5f1d62f86ff2f3c4aa5#36906
Merged
vdemeester merged 1 commit intomoby:masterfrom May 3, 2018
Merged
Bump docker/distribution to 83389a148052d74ac602f5f1d62f86ff2f3c4aa5#36906vdemeester merged 1 commit intomoby:masterfrom
vdemeester merged 1 commit intomoby:masterfrom
Conversation
novas0x2a
force-pushed
the
bump-distribution
branch
from
48383e8 to
560b898
Compare
Codecov Report
@@ Coverage Diff @@
## master #36906 +/- ##
=========================================
Coverage ? 35.35%
=========================================
Files ? 614
Lines ? 45701
Branches ? 0
=========================================
Hits ? 16159
Misses ? 27400
Partials ? 2142 |
vdemeester
requested review from
aaronlehmann,
dmcgowan,
stevvooe,
thaJeztah,
tiborvass and
tonistiigi
Contributor
Author
|
Some of the jenkins builds failed, but it doesn't look like the failures had anything to do with my changes. Can you retrigger? |
Member
|
hm, looks like I don't have an option / permissions to restart the |
Member
|
Full diff is distribution/distribution@edc3ab2...83389a1 |
vendored distribution is quite old, and current distribution contains an API break, which means it's not possible to vendor a bugfixed distribution and a docker/docker at the same time. Signed-off-by: Mike Lundy <[email protected]>
novas0x2a
force-pushed
the
bump-distribution
branch
from
560b898 to
07ffa1c
Compare
Contributor
Author
|
Looks like mostly green this time; presumably (from their names) experimental and janky aren't expected to pass? |
Member
|
Failure on both Janky and Experimental is; could be a flaky test, or something introduced recently; restarting CI on those, let's see if it's flaky or not |
Contributor
Author
|
Heyyyy all green now |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendored distribution is quite old, and current distribution contains an
API break, which means it's not possible to vendor a bugfixed
distribution and docker/docker master at the same time.
Note: locally, TestTarUntarWithXattr fails for me in both this branch and the current master; I'm not sure what's happening, but I don't think it's related to this PR. (I'm hoping the CI tests will pass).
- What I did
Bumped docker/distribution and made the minor changes necessary to deal with that.
- How I did it
Typing frantically until it was done.
- How to verify it
In theory this should be pretty low-impact, since docker/moby doesn't actually use a lot of the distribution package. I'd expect that if it compiles and passes tests, it'd probably work.
- Description for the changelog
Updated vendored copy of docker/distribution to ease projects trying to vendor both moby/moby (docker/docker) and docker/distribution.
- A picture of a cute animal (not mandatory but encouraged)