Skip to content

Bump SwarmKit to remove deprecated grpc metadata wrappers #36905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpuguy83 merged 1 commit into from
Apr 25, 2018
Merged

Bump SwarmKit to remove deprecated grpc metadata wrappers #36905

cpuguy83 merged 1 commit into from
Apr 25, 2018

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 19, 2018

Updates swarmkit to 33d06bf, to bring in
moby/swarmkit#2610 (Don't use wrappers for grpc metadata)

full diff: moby/swarmkit@9c2aa15...33d06bf

ping @dmcgowan @crosbymichael @tonistiigi

@thaJeztah
Bump SwarmKit to remove deprecated grpc metadata wrappers
b18f703 
Updates swarmkit to 33d06bf, to bring in
moby/swarmkit#2610 (Don't use wrappers for grpc metadata)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Apr 19, 2018
Merged
@thaJeztah
Copy link
Member Author

thaJeztah commented Apr 20, 2018

Windows is failing on a flaky test https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/20495/console (tracked through #36350)

23:36:23 ----------------------------------------------------------------------
23:36:23 FAIL: docker_api_logs_test.go:151: DockerSuite.TestLogsAPIUntil
23:36:23 
23:36:23 docker_api_logs_test.go:174:
23:36:23     c.Assert(len(allLogs), checker.GreaterOrEqualThan, 3)
23:36:23 ... obtained int = 1
23:36:23 ... expected int = 3
23:36:23

@vdemeester vdemeester requested a review from tonistiigi April 20, 2018 10:07
@codecov
Copy link

codecov bot commented Apr 25, 2018 •
edited
Loading

Codecov Report

Merging #36905 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #36905      +/-   ##
==========================================
- Coverage   35.24%   34.96%   -0.29%     
==========================================
  Files         614      614              
  Lines       45638    45638              
==========================================
- Hits        16084    15956     -128     
- Misses      27426    27591     +165     
+ Partials     2128     2091      -37

@thaJeztah
Copy link
Member Author

thaJeztah commented Apr 25, 2018

This is green now 👍

@dmcgowan
Copy link
Member

dmcgowan commented Apr 25, 2018

LGTM

1 similar comment
@tonistiigi
Copy link
Member

tonistiigi commented Apr 25, 2018

LGTM

cpuguy83
cpuguy83 approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 28f3736 into moby:master Apr 25, 2018
@thaJeztah thaJeztah deleted the bump-swarmkit branch April 25, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @dmcgowan @tonistiigi @cpuguy83 @GordonTheTurtle