pkg/mount/TestMount: fix wrt selinux#36750
Merged
vdemeester merged 1 commit intomoby:masterfrom May 23, 2018
Merged
Conversation
Member
|
Do we know what makes selinux detection flaky? I agree we can ignore that option, but curious why we fail to properly detect selinux |
Member
|
alternative #36740 |
Contributor
Author
Most probably dind (selinux is detected by checking /sys/fs/selinux mount point which is not there by default). That does not explain flakiness though. |
Contributor
Author
Member
Contributor
Author
|
Reopening; I think this test should not check for seclabel at all |
Codecov Report
@@ Coverage Diff @@
## master #36750 +/- ##
==========================================
- Coverage 35.34% 35.06% -0.28%
==========================================
Files 615 615
Lines 45813 45813
==========================================
- Hits 16194 16066 -128
- Misses 27473 27638 +165
+ Partials 2146 2109 -37 |
kolyshkin
force-pushed
the
t-mount-seclabel
branch
from
8a10841 to
37b1746
Compare
Member
|
experimental https://jenkins.dockerproject.org/job/Docker-PRs-experimental/40569/console failing on |
Sometimes docker-master CI fails on rhel4+selinux configuration,
like this:
--- FAIL: TestMount (0.12s)
--- FAIL: TestMount/none-remount,size=128k (0.01s)
mounter_linux_test.go:209: unexpected mount option "seclabel" expected "rw,size=128k"
--- FAIL: TestMount/none-remount,ro,size=128k (0.01s)
mounter_linux_test.go:209: unexpected mount option "seclabel" expected "ro,size=128k"
Earlier, commit 8bebd42 (PR moby#34965) fixed this failure,
but not entirely (i.e. the test is now flaky). It looks like
either selinux detection code is not always working (it won't
work in d-in-d), or the kernel might or might not add 'seclabel'
option).
As the subject of this test case is definitely not selinux,
it can just ignore the option added by it.
While at it, fix error messages:
- add missing commas;
- fix a typo;
- allow for clear distinction between mount
and vfs (per-superblock) options.
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
|
A different failure on experimental now: haven't seen it before. Rebased. |
kolyshkin
force-pushed
the
t-mount-seclabel
branch
from
37b1746 to
d78e885
Compare
Member
|
I think I've seen #37086 was actually increasing the timeout for swarm tests to address the flakiness, but that was removed in favor of changing the timeout on a test-by-test base (#37086 (comment)) Opened #37132 for the flaky test |
Member
|
New failures (also flaky) in Janky https://jenkins.dockerproject.org/job/Docker-PRs/49536/console tracked through #36877 Looks like the fix in #37086 didn't resolve the problem; this PR has that fix, but is still failing (https://github.com/kolyshkin/moby/blob/d78e885326213e8ef89919c3cc6d16e712e852a8/integration-cli/docker_cli_exec_unix_test.go#L18-L44) Other failure is tracked through #34051 |
This was referenced Aug 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes docker-master CI fails on rhel4+selinux configuration, like this:
Earlier, commit 8bebd42 (PR #34965) fixed this failure, but not entirely (i.e. the test is now flaky). It looks like selinux detection code is not always working.
As the subject of this test case is definitely not selinux, it can just ignore the option added by it.
While at it, fix error messages -- add missing commas, fix a typo, and allow for clear distinction between mount and vfs (per-superblock) options.