Add default pollSettings config functions#36706
Conversation
|
also @dnephin and @thaJeztah 😸 ... |
arm64b
force-pushed
the
add-defult-timeout-config-func
branch
from
3553492 to
a430d37
Compare
|
Hello @vdemeester , would you pls help to rebuild the failure nodes? Thanks! 🐅 |
There was a problem hiding this comment.
I guess we don’t have tests that already set a longer timeout? Otherwise we may have to check first if the existing timeout is longer
There was a problem hiding this comment.
The default timeout value is 10s configured in the 3rd party code github.com/gotestyourself/gotestyourself/poll/poll.go, for each poll.WaitOn() calling, we can override the timeout value with the default function defined here. On Arm platforms, for those multiple-service creation, the 1min value is reasonable and the CI can pass all the test cases. Let me know if any suggestions 😄
There was a problem hiding this comment.
I don't think we have any async image operations, so we won't need this one.
There was a problem hiding this comment.
Thanks for the review 👍 ! I will remove it in the update, even we need this one in the future, I think it will be easy to extend this idea.
There was a problem hiding this comment.
I don't think we have any async plugin operations, so we won't need this one.
There was a problem hiding this comment.
I don't think we have any async volume operations, so we won't need this one.
There was a problem hiding this comment.
these are waiting on services, so shouldn't it use ServicePoll?
There was a problem hiding this comment.
Right, I'll correct it.
arm64b
force-pushed
the
add-defult-timeout-config-func
branch
from
a430d37 to
a742046
Compare
Codecov Report
@@ Coverage Diff @@
## master #36706 +/- ##
=========================================
Coverage ? 35%
=========================================
Files ? 613
Lines ? 45797
Branches ? 0
=========================================
Hits ? 16030
Misses ? 27675
Partials ? 2092 |
|
Hello @vdemeester , thanks for the quick response! Seems the |
|
ping @dnephin , @thaJeztah , PTAL? |
There was a problem hiding this comment.
Many of these are waiting on service state, so they should use ServicePoll.
Add the default function per resource to override the `pollSettings` which will be re-used where it's needed. Signed-off-by: Dennis Chen <[email protected]>
Using the default PollSettings functions to adjust the timeout value instead of changing the value each time when needed. Signed-off-by: Dennis Chen <[email protected]>
arm64b
force-pushed
the
add-defult-timeout-config-func
branch
from
a742046 to
b8912fe
Compare
|
Hello @dnephin , kindly PTAL again after the change according to your comments ❓ |
6 participants
This PR will:
pollSettingswhich will be re-used where it's needed, this will avoid to configure the timeout value each time.- What I did
Override the timeout value for some time-consuming test cases.
- How I did it
Add default function to override the timeout value per resource, and reuse it where it's needed.
- How to verify it
make test-integration- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)