Extract volume interaction to a volumes service#36688
Conversation
cpuguy83
force-pushed
the
volumes_service
branch
2 times, most recently
from
c7109af to
4b5957c
Compare
There was a problem hiding this comment.
This seems to be a very different abstraction from what we are calling services currently (ex: ImageService, and RegistryService) which implement higher level logic.
Most of this interface is implemented by the VolumeStore, right?
I would think a VolumeService would be a type that implements api/server/router/volume.Backend, as well as whatever is used by other services. That way we remove the need for a monolithic daemon package.
I like the changes in this PR, but it seems that we're losing the ability to create a VolumeService to replace the daemon methods for volumes.
Could this continue to be a VolumeStore, and we split out a service later?
There was a problem hiding this comment.
We could call it that still... but that (replace daemon methods) is indeed the intent, it's just yet more change to add in this large PR, of course can add a commit to make that happen.
cpuguy83
force-pushed
the
volumes_service
branch
from
4b5957c to
0f566d3
Compare
cpuguy83
force-pushed
the
volumes_service
branch
from
0f566d3 to
5eefc91
Compare
cpuguy83
changed the title
cpuguy83
force-pushed
the
volumes_service
branch
2 times, most recently
from
983da3c to
eaac2a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #36688 +/- ##
==========================================
- Coverage 35.05% 34.93% -0.13%
==========================================
Files 615 609 -6
Lines 45828 44973 -855
==========================================
- Hits 16065 15711 -354
+ Misses 27652 27136 -516
- Partials 2111 2126 +15 |
cpuguy83
force-pushed
the
volumes_service
branch
9 times, most recently
from
511108e to
81b74d8
Compare
cpuguy83
changed the title
cpuguy83
force-pushed
the
volumes_service
branch
3 times, most recently
from
f1c8283 to
e14f9b3
Compare
cpuguy83
force-pushed
the
volumes_service
branch
2 times, most recently
from
92981fd to
a5466d5
Compare
|
Updated and all green. |
This cleans up some of the package API's used for interacting with volumes, and simplifies management. Signed-off-by: Brian Goff <[email protected]>
|
ping @anusha-ragunathan PTAL |
|
LGTM |
|
@cpuguy83 unit tests TestServiceCreate/TestServiceGet may fail
|
8 participants
This cleans up some of the package API's used for interacting with volumes, and simplifies management.
This is built on top of #36637.
I've done a lot of manual testing on this, but would like to add some more tests especially around the filtering logic, which is also now consolidated to the volume service.