client: fix hijackedconn reading from buffer#36663
Merged
Merged
Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
thaJeztah
added
status/2-code-review
rebuild/windowsRS1
and removed
status/0-triage
labels
Member
|
|
Contributor
|
thanks @tonistiigi |
Codecov Report
@@ Coverage Diff @@
## master #36663 +/- ##
=========================================
Coverage ? 34.71%
=========================================
Files ? 613
Lines ? 45767
Branches ? 0
=========================================
Hits ? 15888
Misses ? 27807
Partials ? 2072 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36656
Regression from #36517
With the direct cast, the
Readmethod is not inherited and the read doesn't go to the buffer but directly to the raw connection.@jim-minter
Signed-off-by: Tonis Tiigi [email protected]