Merged
Conversation
cpuguy83
force-pushed
the
no_global_driver_store
branch
from
ae8d570 to
37cb8d0
Compare
cpuguy83
added
status/2-code-review
rebuild/experimental
and removed
status/0-triage
labels
cpuguy83
force-pushed
the
no_global_driver_store
branch
from
37cb8d0 to
1f77321
Compare
Codecov Report
@@ Coverage Diff @@
## master #36637 +/- ##
==========================================
- Coverage 35.2% 35.15% -0.06%
==========================================
Files 614 613 -1
Lines 45698 45623 -75
==========================================
- Hits 16090 16040 -50
+ Misses 27473 27463 -10
+ Partials 2135 2120 -15 |
thaJeztah
reviewed
Mar 23, 2018
volume/drivers/proxy.go
Outdated
Member
There was a problem hiding this comment.
Does something else need to be updated, because this is generated code?
Member
Author
There was a problem hiding this comment.
No, it just takes the package name from the package it's being run from.
thaJeztah
reviewed
Mar 23, 2018
Member
There was a problem hiding this comment.
This change should probably go into the other commit that removes the old code
cpuguy83
force-pushed
the
no_global_driver_store
branch
from
1f77321 to
75de57c
Compare
Contributor
|
Looks good overall. The change description threw me off a bit. "No global volume driver store" can also be interpreted "No more metadata.db" which is a big change. Can you reword the description to mean that you are talking about an internal data structure change? |
Member
Author
|
@anusha-ragunathan This isn't removing metadata.db |
Contributor
|
@cpuguy83 : Yes I know, but the change description can be misinterpreted to mean that. I'm just asking you to re-word the commit description. i.e "No global volume driver store" can be reworded. |
Member
|
ugh needs a rebase now 😥 |
Since the volume store already provides this functionality, we should just use it rather than duplicating it. Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Instead of using a global store for volume drivers, scope the driver store to the caller (e.g. the volume store). This makes testing much simpler. Signed-off-by: Brian Goff <[email protected]>
Member
Author
|
Rebased and added more details to the commit message. |
cpuguy83
force-pushed
the
no_global_driver_store
branch
from
75de57c to
977109d
Compare
Member
|
Failure on s390 (https://jenkins.dockerproject.org/job/Docker-PRs-s390x/9399/console) is being tracked through #36877; |
Member
|
Failure on experimentalalso should not be related https://jenkins.dockerproject.org/job/Docker-PRs-experimental/40285/console: |
Contributor
|
LGTM |
thaJeztah
added
status/4-merge
area/volumes
Member
|
Experimental failing again, on another test; https://jenkins.dockerproject.org/job/Docker-PRs-experimental/40287/console |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors volume driver storage to not use a global store.
This makes things a bit nicer to deal with, especially in tests which are now much more easily parallelized.