Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration/TestExportContainerAfterDaemonRestart: add #36606

Merged
merged 1 commit into from
Mar 16, 2018
Merged

integration/TestExportContainerAfterDaemonRestart: add #36606

merged 1 commit into from
Mar 16, 2018

Conversation

kolyshkin
Copy link
Contributor

This test case checks that a container created before start of the currently running dockerd can be exported (as reported in #36561). To satisfy this condition, either a pre-existing container is required, or a daemon restart after container creation.

@kolyshkin
integration/TestExportContainerAfterDaemonRestart: add
6e7141c 
This test case checks that a container created before start
of the currently running dockerd can be exported (as reported
in moby#36561). To satisfy this condition, either a pre-existing
container is required, or a daemon restart after container
creation.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin mentioned this pull request Mar 15, 2018
Merged
vdemeester
vdemeester approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

integration/container/export_test.go
// condition, daemon restart is needed after container creation.
func TestExportContainerAfterDaemonRestart(t *testing.T) {
skip.If(t, testEnv.DaemonInfo.OSType != "linux")
skip.If(t, testEnv.IsRemoteDaemon())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@vdemeester vdemeester mentioned this pull request Mar 15, 2018
Closed
thaJeztah
thaJeztah approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
Copy link
Contributor Author

OK so it seems the new test is working.

A couple of unrelated failures:

ppc

01:05:02 === RUN TestCreateServiceConfigFileMode
01:05:14 --- FAIL: TestCreateServiceConfigFileMode (11.64s)
01:05:14 daemon.go:283: [d42bcf5fb1d32] waiting for daemon to start
01:05:14 daemon.go:315: [d42bcf5fb1d32] daemon started
01:05:14 create_test.go:280: timeout hit after 10s: task count at 3 waiting for 1
01:05:14 daemon.go:273: [d42bcf5fb1d32] exiting daemon

s390

01:24:56 PASS: docker_api_containers_test.go:1285: DockerSuite.TestPostContainerAPICreateWithStringOrSliceEntrypoint 1.645s
01:25:04
01:25:04 ----------------------------------------------------------------------
01:25:04 FAIL: docker_api_attach_test.go:98: DockerSuite.TestPostContainersAttach
01:25:04
01:25:04 docker_api_attach_test.go:211:
01:25:04 c.Assert(actualStdout.Bytes(), checker.DeepEquals, []byte("hello\nsuccess"), check.Commentf("Attach didn't return the expected data from stdout"))
01:25:04 ... obtained []uint8 = []byte{0x73, 0x75, 0x63, 0x63, 0x65, 0x73, 0x73}
01:25:04 ... expected []uint8 = []byte{0x68, 0x65, 0x6c, 0x6c, 0x6f, 0xa, 0x73, 0x75, 0x63, 0x63, 0x65, 0x73, 0x73}
01:25:04 ... Attach didn't return the expected data from stdout
01:25:04

the last test case was added by @ncdc in #26718
Andy, do you have any idea why it may occasionally fail?

@ncdc
Copy link
Contributor

ncdc commented Mar 15, 2018

@kolyshkin it looks like the output obtained was success, so the test missed the "logs" portion of the test (hello\n). I have no idea why it might fail - I haven't been involved with the moby code base in a long time. Sorry!

@thaJeztah thaJeztah mentioned this pull request Mar 16, 2018
Merged
@kolyshkin kolyshkin mentioned this pull request Mar 16, 2018
Closed
@thaJeztah thaJeztah mentioned this pull request Mar 16, 2018
Merged
@thaJeztah
Copy link
Member

Issue was added to track the flaky/broken test: #36611

@vdemeester vdemeester merged commit 823de22 into moby:master Mar 16, 2018
@kolyshkin kolyshkin deleted the t-36561 branch March 20, 2018 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@dnephin dnephin Awaiting requested review from dnephin

Assignees
No one assigned
Labels
area/testing platform/windows status/4-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kolyshkin @ncdc @thaJeztah @vdemeester @GordonTheTurtle