Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration-cli/TestSlowStdinClosing: increase timeout #36571

Merged
merged 1 commit into from
Mar 14, 2018
Merged

integration-cli/TestSlowStdinClosing: increase timeout #36571

merged 1 commit into from
Mar 14, 2018

Conversation

kolyshkin
Copy link
Contributor

I noticed this test failed on Windows:

17:46:24 docker_cli_run_test.go:4361:
17:46:24 c.Fatal("running container timed out") // cleanup in teardown

I also noticed that in general tests are running slower on Windows, for example TestStartAttachSilen (which runs a container with busybox echo test and then starts it again) took 29.763s. This means a simple container start can easily take 15s, which explains the above failure.

Double the timeout from 15s to 30s.

Fixes: 4e262f6 ("Fix race on sending stdin close event")

@kolyshkin
integration-cli/TestSlowStdinClosing: increase timeout
5043639 
I noticed this test failed on Windows:

> 17:46:24 docker_cli_run_test.go:4361:
> 17:46:24 c.Fatal("running container timed out") // cleanup in teardown

I also noticed that in general tests are running slower on Windows,
for example TestStartAttachSilent (which runs a container with
`busybox echo test` and then starts it again) took 29.763s.
This means a simple container start can easily take 15s, which
explains the above failure.

Double the timeout from 15s to 30s.

Fixes: 4e262f6 ("Fix race on sending stdin close event")
Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin mentioned this pull request Mar 13, 2018
Merged
@kolyshkin
Copy link
Contributor Author

@tonistiigi PTAL

@thaJeztah thaJeztah mentioned this pull request Mar 13, 2018
Merged
@thaJeztah
Copy link
Member

experimental is failing on https://jenkins.dockerproject.org/job/Docker-PRs-experimental/39760/console (tracked through #36547)

04:03:02 --- FAIL: TestServiceWithPredefinedNetwork (11.82s)
04:03:02 	daemon.go:283: [db5c14e9e62fb] waiting for daemon to start
04:03:02 	daemon.go:315: [db5c14e9e62fb] daemon started
04:03:02 	service_test.go:52: timeout hit after 10s: task count at 1 waiting for 0
04:03:02 	daemon.go:273: [db5c14e9e62fb] exiting daemon

powerpc failing on https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/8967/console (may want to open an issue for that one as well, as I've seen it fail frequently)

04:06:09 --- FAIL: TestCreateServiceConfigFileMode (11.70s)
04:06:09 	daemon.go:283: [d2f8595d642d4] waiting for daemon to start
04:06:09 	daemon.go:315: [d2f8595d642d4] daemon started
04:06:09 	create_test.go:280: timeout hit after 10s: task count at 3 waiting for 1
04:06:09 	daemon.go:273: [d2f8595d642d4] exiting daemon

thaJeztah
thaJeztah approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

ping @johnstep PTAL

johnstep
johnstep approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@johnstep johnstep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Hm, another flaky test on experimental? DockerSuite.TestRunInteractiveWithRestartPolicy

https://jenkins.dockerproject.org/job/Docker-PRs-experimental/39782/console

03:03:04 ----------------------------------------------------------------------
03:03:04 FAIL: docker_cli_run_test.go:1790: DockerSuite.TestRunInteractiveWithRestartPolicy
03:03:04 
03:03:04 docker_cli_run_test.go:1803:
03:03:04     result.Assert(c, icmd.Expected{ExitCode: 11})
03:03:04 /go/src/github.com/docker/docker/vendor/github.com/gotestyourself/gotestyourself/icmd/command.go:65:
03:03:04     t.Fatalf(err.Error() + "\n")
03:03:04 ... Error: 
03:03:04 Command:  /usr/local/cli/docker run -i --name test-inter-restart --restart=always busybox sh
03:03:04 ExitCode: 0
03:03:04 Error:    <nil>
03:03:04 Stdout:   
03:03:04 Stderr:   
03:03:04 
03:03:04 Failures:
03:03:04 ExitCode was 0 expected 11
03:03:04

@thaJeztah
Copy link
Member

Looks like that one was flaky a couple of times in the past https://github.com/moby/moby/search?q=TestRunInteractiveWithRestartPolicy&type=Issues&utf8=✓ (also #27078)

@thaJeztah
Copy link
Member

Merging this one, because the failure should not be related to this change

@thaJeztah thaJeztah merged commit 592a15b into moby:master Mar 14, 2018
@tonistiigi tonistiigi mentioned this pull request Mar 14, 2018
Closed
This was referenced Mar 15, 2018
Merged
Merged
@kolyshkin kolyshkin mentioned this pull request Mar 16, 2018
Merged
@thaJeztah thaJeztah mentioned this pull request Mar 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@johnstep johnstep johnstep approved these changes

@dnephin dnephin Awaiting requested review from dnephin

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
area/testing platform/windows status/4-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kolyshkin @thaJeztah @tonistiigi @johnstep @vdemeester @yongtang @GordonTheTurtle