Skip to content

[integration] skip ppc64le oom tests temporarily#36539

Merged
vdemeester merged 1 commit intomoby:masterfrom
tophj-ibm:skip-oom-tests-ppc64le
Mar 9, 2018
Merged

[integration] skip ppc64le oom tests temporarily#36539
vdemeester merged 1 commit intomoby:masterfrom
tophj-ibm:skip-oom-tests-ppc64le

Conversation

@tophj-ibm
Copy link
Contributor

These tests were enabled by changing a config option on the ci
machines, instead of from a patch, so let me disable them
for now on ppc64le and open up another patch to enable them, where I can find
out what the issues are with them.

Signed-off-by: Christopher Jones [email protected]

Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems to be passing still or was it failing as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm, meant the DisableFalse one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah all three fail. This one is a bit flakier

@thaJeztah
Copy link
Member

erm, whoops:

23:25:19 integration-cli/docker_cli_events_unix_test.go:52:84: undefined: notPpc64le
23:25:19 integration-cli/docker_cli_events_unix_test.go:82:92: undefined: notPpc64le
23:25:19 integration-cli/docker_cli_run_unix_test.go:618:57: undefined: notPpc64le

These tests were enabled by changing a config option on the ci
machines, instead of from a patch, so let me disable them
for now on ppc64le and open up another patch to enable them, where I can find
out what the issues are with them.

Signed-off-by: Christopher Jones <[email protected]>
@tophj-ibm tophj-ibm force-pushed the skip-oom-tests-ppc64le branch from 86c5796 to 620ddc7 Compare March 8, 2018 23:52
@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0c01629). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36539   +/-   ##
=========================================
  Coverage          ?   34.64%           
=========================================
  Files             ?      613           
  Lines             ?    45404           
  Branches          ?        0           
=========================================
  Hits              ?    15730           
  Misses            ?    27615           
  Partials          ?     2059

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Windows failure is unrelated

03:29:01 FAIL: docker_api_logs_test.go:23: DockerSuite.TestLogsAPIWithStdout
03:29:01 
03:29:01 docker_api_logs_test.go:55:
03:29:01     c.Fatal("timeout waiting for logs to exit")
03:29:01 ... Error: timeout waiting for logs to exit
03:29:01 

@thaJeztah
Copy link
Member

Janky is failing because of these; #36501 (also unrelated)

PowerPC is green, which is the important one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants