Skip to content

Rename integration/util to integration/internal#36265

Merged
vdemeester merged 1 commit intomoby:masterfrom
vdemeester:rename-integration-util-to-internal
Feb 10, 2018
Merged

Rename integration/util to integration/internal#36265
vdemeester merged 1 commit intomoby:masterfrom
vdemeester:rename-integration-util-to-internal

Conversation

@vdemeester
Copy link
Copy Markdown
Member

Both names have no real sense, but one allows to make sure these packages
aren't used outside of integration.

😝 🌵

Signed-off-by: Vincent Demeester [email protected]

Copy link
Copy Markdown
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongtang
Copy link
Copy Markdown
Member

yongtang commented Feb 9, 2018

@vdemeester There seems to be one conflict:

22:05:17 integration/container/inspect_test.go:12:2:warning: could not import github.com/docker/docker/integration/util/request (cannot find package "github.com/docker/docker/integration/util/request" in any of: (gosimple)
22:05:17 Build step 'Execute shell' marked build as failure

Can you take a look?

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if CI is fixed)

Both names have no real sense, but one allows to make sure these packages
aren't used outside of `integration`.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the rename-integration-util-to-internal branch from 62d9e22 to af306d1 Compare February 10, 2018 08:16
@vdemeester
Copy link
Copy Markdown
Member Author

rebased 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants