Skip to content

Migrate TestKillDifferentUserContainer to api test#36259

Merged
yongtang merged 1 commit intomoby:masterfrom
yongtang:02082018-kill_test
Feb 9, 2018
Merged

Migrate TestKillDifferentUserContainer to api test#36259
yongtang merged 1 commit intomoby:masterfrom
yongtang:02082018-kill_test

Conversation

@yongtang
Copy link
Copy Markdown
Member

@yongtang yongtang commented Feb 9, 2018

This fix migrates TestKillDifferentUserContainer to api test

Signed-off-by: Yong Tang [email protected]

Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌵

Comment thread integration/container/kill_test.go Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we print "Windows does not support -u" in the skip ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the message should be different as we're not using the cli at all

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdemeester Updated. Thanks.

This fix migrates TestKillDifferentUserContainer to api test

Signed-off-by: Yong Tang <[email protected]>
Copy link
Copy Markdown
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants