Enable OOM Kill events integration test#36229
Conversation
Now that the `-m` flag can work in case of cgroup swap memory limit isn't enabled, also we have PR moby#36201 merged, so now we can remove the `swapMemorySupport` from `testRequires()` order to trigger the real test on those platforms which don't enable cgroup swap mem limit. Signed-off-by: Dennis Chen <[email protected]>
|
Relevant commit for this PR: commit 3abf2a77414195d5b0c15f7fc88b7fd9aa4edaa8 And we snapshot one CI log on |
|
From the CI result, seems the Anyway this change will put those OOM kill event tests into practice while not just simply skip it on all platforms, for example, those tests output on |
|
I don't think removing swapMemorySupport is the correct solution here, I think instead we want to enable swap limiting capabilities in all the CI machines so this test is run as is. I think the issue with one of the |
|
Right! So I am thinking about if we can figure out a method to trigger the OOM state quickly in case of CI machines don't enable the cgroup swap limit configuration? |
|
@arm64b I sent a message to one of the people who maintains these machines and asked to get it enabled. |
|
Hello @tophj-ibm I agree that will be final solution to do that, although we do have the intention to put those test cases into practice to trigger the real issues asap. I think now we can close this PR... |
Now that the
-mflag can work in case of cgroup swap memory limitisn't enabled, also we have PR #36201 merged, so now we can remove
the
swapMemorySupportfromtestRequires()order to trigger the realtest on those platforms which don't enable cgroup swap mem limit.
Signed-off-by: Dennis Chen [email protected]
- What I did
Trigger OOM Kill events integration tests
- How I did it
Remove
swapMemorySupportfromtestRequires()- How to verify it
make test-integration- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)