Skip oom-kill test on AArch64#36185
Conversation
Currently the '--oom-kill-disable' flag doesn't work at all, so now let's skip this test case on AArch64 avoiding block our CI testing pipeline. Signed-off-by: Dennis Chen <[email protected]>
|
According to our practical testing, the That works for the |
|
Curious, what exactly is it failing with? This test was skipped on arm32 because it was failing, but I don't think anyone ever looked at it #19412 I'll add that the flag works correctly with both docker and runc on |
|
@tophj-ibm Although this issue is triggered by AArch64 platform, but after some investigation, we found that it's not Arch-specific, we have an initial fixing solution for this issue in PR #36201. Interesting all the arches (amd64, s390, ppc...) have |
|
You're correct. I was testing with docker-ee which oddly doesn't have this isssue. Building from upstream however, I did encounter it (and saw it was fixed by your PR)! |
|
Ah, You remind me to test with 17.12.0-ce, the issue is there, but I haven't docker-ee version at hand now... |
|
Let’s close this in favor of #36201, which looks like the correct fix (thanks!) |
Currently the '--oom-kill-disable' flag doesn't work at all, so now
let's skip this test case on AArch64 avoiding block our CI testing
pipeline.
Signed-off-by: Dennis Chen [email protected]
- What I did
Skip the
TestEventsOOMDisableTrueon AArch64- How I did it
Update the test requires
NotArm64- How to verify it
make test-integrationon AArch64 platform- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)