Test for systemd cgroupdriver memory setting #36172

kolyshkin · 2018-01-31T21:47:33Z

This is a test case for issue #35123, making sure we can set container's memory limit when using native.cgroupdriver=systemd.

kolyshkin · 2018-02-01T01:54:42Z

No systemd in CI 🛑

kolyshkin · 2018-02-01T21:41:30Z

The current idea is to have this test, but add a t.Skip() in case systemd is not available (which is the case with the current CI). If the test environment will feature systemd, the test will run.

kolyshkin · 2018-02-01T23:01:14Z

OK, this is good to go for current CI. Still need to check if the test works in an environment with systemd.

14:18:52 --- SKIP: TestCgroupDriverSystemdMemoryLimit (0.00s)
14:18:52 	cgroupdriver_systemd_test.go:33: systemd not available

kolyshkin · 2018-02-02T00:45:20Z

And the older failure message looked like:

13:59:35 --- FAIL: TestCgroupDriverSystemdMemoryLimit (0.88s)
13:59:35 	daemon.go:285: [d4b3033d942ed] waiting for daemon to start
13:59:35 	daemon.go:317: [d4b3033d942ed] daemon started
13:59:35 	assertions.go:226: 
                          
	Error Trace:	cgroupdriver_systemd_test.go:42
13:59:35 		
	Error:      	Received unexpected error:
13:59:35 		
	            	Error response from daemon: OCI runtime create failed: systemd cgroup flag passed, but systemd support for managing cgroups is not available: unknown
13:59:35 	daemon.go:275: [d4b3033d942ed] exiting daemon

kolyshkin · 2018-03-07T01:19:53Z

Same unrelated failure on ppc and experimenal:

04:02:02 ----------------------------------------------------------------------
04:02:02 FAIL: check_test.go:366: DockerSwarmSuite.TearDownTest
04:02:02
04:02:02 unmount of /tmp/docker-execroot/d1825ad513bf4/netns failed: invalid argument
04:02:02 unmount of /tmp/docker-execroot/d1825ad513bf4/netns failed: no such file or directory
04:02:02 check_test.go:371:
04:02:02 d.Stop(c)
04:02:02 daemon/daemon.go:389:
04:02:02 t.Fatalf("Error while stopping the daemon %s : %v", d.id, err)
04:02:02 ... Error: Error while stopping the daemon d4a5ccddf48ee : exit status 130
04:02:02

I am seeing it for other PRs as well, guess some recent swarm or dockerd changes caused it.

kolyshkin · 2018-03-07T01:20:56Z

This is skipped in current CI but can be potentially usable for environment having systemd

boaz0

LGTM 👍

cpuguy83 · 2018-03-12T19:12:08Z

integration/system/cgroupdriver_systemd_test.go

+	d := daemon.New(t, "docker", "dockerd", daemon.Config{})
+	client, err := d.NewClient()
+	require.NoError(t, err)
+	d.StartWithBusybox(t, "--exec-opt", "native.cgroupdriver=systemd")


If using t.Parallel(), you must use --iptables=false

Thanks for catching, fixed!

(detailed explanation is in commit 9e31938)

codecov · 2018-03-12T21:41:34Z

Codecov Report

❗ No coverage uploaded for pull request base (master@7270b01). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36172   +/-   ##
=========================================
  Coverage          ?   34.87%           
=========================================
  Files             ?      612           
  Lines             ?    45801           
  Branches          ?        0           
=========================================
  Hits              ?    15973           
  Misses            ?    27759           
  Partials          ?     2069

cpuguy83

LGTM

kolyshkin · 2018-03-13T01:13:33Z

failure on Z is unrelated (#36547):

15:02:46 === RUN   TestServiceWithPredefinedNetwork
15:02:58 --- FAIL: TestServiceWithPredefinedNetwork (12.14s)
15:02:58 	daemon.go:283: [d71b928c0b500] waiting for daemon to start
15:02:58 	daemon.go:315: [d71b928c0b500] daemon started
15:02:58 	service_test.go:52: timeout hit after 10s: task count at 1 waiting for 0
15:02:58 	daemon.go:273: [d71b928c0b500] exiting daemon
15:02:58 FAIL

An interesting failure on powerpc:

15:21:41 === RUN   TestLinksEtcHostsContentMatch
15:21:41 --- FAIL: TestLinksEtcHostsContentMatch (0.53s)
15:21:41 	assertions.go:226: 
                          
	Error Trace:	links_linux_test.go:46
15:21:41 		
	Error:      	Not equal: 
15:21:41 		
	            	expected: "127.0.0.1\tlocalhost\n::1\tlocalhost ip6-localhost ip6-loopback\nfe00::0\tip6-localnet\nff00::0\tip6-mcastprefix\nff02::1\tip6-allnodes\nff02::2\tip6-allrouters\n172.17.0.2\tf53feb6df161\n"
15:21:41 		
	            	received: ""

Filed #36569 as a possible fix.

vdemeester

LGTM 🐯

kolyshkin · 2018-03-15T06:47:09Z

rebased (for the sake of merged fixes for unrelated test failures)

vdemeester · 2018-03-19T09:21:53Z

@kolyshkin needs a rebase (😓)

09:06:06 integration/system/cgroupdriver_systemd_test.go:12:2: cannot find package "github.com/stretchr/testify/require" in any of:
09:06:06 	/go/src/github.com/docker/docker/vendor/github.com/stretchr/testify/require (vendor tree)
09:06:06 	/usr/local/go/src/github.com/stretchr/testify/require (from $GOROOT)
09:06:06 	/go/src/github.com/stretchr/testify/require (from $GOPATH)

This is a test case for issue moby#35123, making sure we can set container's memory limit when using `native.cgroupdriver=systemd`. [v2: skip if no systemd present] [v3: add --iptables=false to avoid flaky tests with t.Parallel()] [v4: rebase after PR#36507 merge] Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin · 2018-03-20T02:07:40Z

Unrelated failure on experimental (logs here), subject of #36611:

15:17:08 FAIL: docker_api_attach_test.go:98: DockerSuite.TestPostContainersAttach
15:17:08 
15:17:08 docker_api_attach_test.go:211:
15:17:08     c.Assert(actualStdout.Bytes(), checker.DeepEquals, []byte("hello\nsuccess"), check.Commentf("Attach didn't return the expected data from stdout"))
15:17:08 ... obtained []uint8 = []byte{0x73, 0x75, 0x63, 0x63, 0x65, 0x73, 0x73}
15:17:08 ... expected []uint8 = []byte{0x68, 0x65, 0x6c, 0x6c, 0x6f, 0xa, 0x73, 0x75, 0x63, 0x63, 0x65, 0x73, 0x73}
15:17:08 ... Attach didn't return the expected data from stdout

Unrelated failure on janky (logs here), subject of #34051:

16:08:14 ----------------------------------------------------------------------
16:08:14 FAIL: docker_cli_swarm_test.go:1147: DockerSwarmSuite.TestSwarmLockUnlockCluster
16:08:14 
16:08:14 [dbf4eb7502d12] waiting for daemon to start
16:08:14 [dbf4eb7502d12] daemon started
16:08:14 
16:08:14 [d4f99a4eda833] waiting for daemon to start
16:08:14 [d4f99a4eda833] daemon started
16:08:14 
16:08:14 [da5bcf1bc8b39] waiting for daemon to start
16:08:14 [da5bcf1bc8b39] daemon started
16:08:14 
16:08:14 [d4f99a4eda833] exiting daemon
16:08:14 [d4f99a4eda833] waiting for daemon to start
16:08:14 [d4f99a4eda833] daemon started
16:08:14 
16:08:14 docker_cli_swarm_test.go:1154:
16:08:14     c.Assert(getNodeStatus(c, d2), checker.Equals, swarm.LocalNodeStateActive)
16:08:14 ... obtained swarm.LocalNodeState = "pending"
16:08:14 ... expected swarm.LocalNodeState = "active"
16:08:14 
16:08:14 [dbf4eb7502d12] exiting daemon
16:08:14 [d4f99a4eda833] exiting daemon
16:08:14 [da5bcf1bc8b39] exiting daemon
16:08:28 
16:08:28 ----------------------------------------------------------------------

thaJeztah · 2018-03-22T12:36:32Z

It's green now, flaky tests passed 👍

kolyshkin requested review from dnephin and vdemeester as code owners January 31, 2018 21:47

GordonTheTurtle added the status/0-triage label Jan 31, 2018

thaJeztah added area/runtime status/2-code-review area/testing and removed status/0-triage labels Jan 31, 2018

kolyshkin closed this Feb 1, 2018

kolyshkin reopened this Feb 1, 2018

kolyshkin force-pushed the systemd-memlimit branch from f4fa6c9 to 854779a Compare February 1, 2018 22:07

GordonTheTurtle assigned dnephin Feb 15, 2018

kolyshkin changed the title ~~[do not merge] Test for systemd cgroupdriver memory setting~~ Test for systemd cgroupdriver memory setting Mar 7, 2018

boaz0 approved these changes Mar 7, 2018

View reviewed changes

thaJeztah added the area/systemd label Mar 7, 2018

cpuguy83 requested changes Mar 12, 2018

View reviewed changes

kolyshkin force-pushed the systemd-memlimit branch from 854779a to 99848c4 Compare March 12, 2018 21:41

kolyshkin force-pushed the systemd-memlimit branch from 99848c4 to b09de47 Compare March 12, 2018 21:43

cpuguy83 approved these changes Mar 13, 2018

View reviewed changes

vdemeester added rebuild/powerpc labels Mar 13, 2018

GordonTheTurtle removed rebuild/powerpc labels Mar 13, 2018

vdemeester approved these changes Mar 13, 2018

View reviewed changes

thaJeztah added status/4-merge rebuild/z and removed status/2-code-review labels Mar 14, 2018

GordonTheTurtle removed the rebuild/z label Mar 14, 2018

kolyshkin force-pushed the systemd-memlimit branch from b09de47 to e2e4fda Compare March 15, 2018 06:46

cpuguy83 added rebuild/experimental labels Mar 15, 2018

GordonTheTurtle removed rebuild/experimental labels Mar 15, 2018

vdemeester added rebuild/experimental labels Mar 19, 2018

GordonTheTurtle removed rebuild/experimental labels Mar 19, 2018

kolyshkin force-pushed the systemd-memlimit branch from e2e4fda to 4ca5c53 Compare March 19, 2018 17:33

vdemeester added rebuild/janky labels Mar 22, 2018

GordonTheTurtle removed rebuild/janky labels Mar 22, 2018

thaJeztah merged commit e2bede0 into moby:master Mar 22, 2018

This was referenced Mar 22, 2018

[18.03] Test for systemd cgroupdriver memory setting docker-archive/docker-ce#476

Merged

Containers fail to start when using --memory in docker 17.09.0-ce #35123

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test for systemd cgroupdriver memory setting #36172

Test for systemd cgroupdriver memory setting #36172

kolyshkin commented Jan 31, 2018 •

edited

Loading

kolyshkin commented Feb 1, 2018

kolyshkin commented Feb 1, 2018 •

edited

Loading

kolyshkin commented Feb 1, 2018

kolyshkin commented Feb 2, 2018

kolyshkin commented Mar 7, 2018 •

edited

Loading

kolyshkin commented Mar 7, 2018

boaz0 left a comment

cpuguy83 Mar 12, 2018

kolyshkin Mar 12, 2018

codecov bot commented Mar 12, 2018 •

edited

Loading

cpuguy83 left a comment

kolyshkin commented Mar 13, 2018 •

edited

Loading

vdemeester left a comment

kolyshkin commented Mar 15, 2018

vdemeester commented Mar 19, 2018

kolyshkin commented Mar 20, 2018

thaJeztah commented Mar 22, 2018

Test for systemd cgroupdriver memory setting #36172

Test for systemd cgroupdriver memory setting #36172

Conversation

kolyshkin commented Jan 31, 2018 • edited Loading

kolyshkin commented Feb 1, 2018

kolyshkin commented Feb 1, 2018 • edited Loading

kolyshkin commented Feb 1, 2018

kolyshkin commented Feb 2, 2018

kolyshkin commented Mar 7, 2018 • edited Loading

kolyshkin commented Mar 7, 2018

boaz0 left a comment

Choose a reason for hiding this comment

cpuguy83 Mar 12, 2018

Choose a reason for hiding this comment

kolyshkin Mar 12, 2018

Choose a reason for hiding this comment

codecov bot commented Mar 12, 2018 • edited Loading

Codecov Report

cpuguy83 left a comment

Choose a reason for hiding this comment

kolyshkin commented Mar 13, 2018 • edited Loading

vdemeester left a comment

Choose a reason for hiding this comment

kolyshkin commented Mar 15, 2018

vdemeester commented Mar 19, 2018

kolyshkin commented Mar 20, 2018

thaJeztah commented Mar 22, 2018

kolyshkin commented Jan 31, 2018 •

edited

Loading

kolyshkin commented Feb 1, 2018 •

edited

Loading

kolyshkin commented Mar 7, 2018 •

edited

Loading

codecov bot commented Mar 12, 2018 •

edited

Loading

kolyshkin commented Mar 13, 2018 •

edited

Loading