LCOW remotefs - return error in Read() implementation#36051
Merged
Conversation
lowenna
force-pushed
the
jjh/remotefs-read-return-error
branch
from
59c9125 to
3c69a38
Compare
gupta-ak
reviewed
Jan 18, 2018
Contributor
gupta-ak
left a comment
gupta-ak
left a comment
There was a problem hiding this comment.
I also see the same bug in lines 108 and 171.
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
jjh/remotefs-read-return-error
branch
from
3c69a38 to
6112ad6
Compare
Member
Author
|
@gupta-ak Yes, you're right. Good catch, thanks. Updated. |
Contributor
|
LGTM |
thaJeztah
added
the
area/lcow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
Found while debugging a slew of LCOW bugs. Turns out if
getResponsefails in the remoteFSRead()implementation, the error isn't returned back. Very simple fix.@gupta-ak @jterry75 FYI. @johnstep PTAL.