Skip to content

Fix timeout issue of multi-services creation on AArch64#35998

Merged
thaJeztah merged 1 commit intomoby:masterfrom
arm64b:fix-timeout-multi-services
Jan 13, 2018
Merged

Fix timeout issue of multi-services creation on AArch64#35998
thaJeztah merged 1 commit intomoby:masterfrom
arm64b:fix-timeout-multi-services

Conversation

@arm64b
Copy link
Copy Markdown
Contributor

@arm64b arm64b commented Jan 12, 2018

Now we only adjust the timeout value for arm while not arm64,
actually the avarage duration for this test is about 25s to create
multiple services on arm64, else the integration test will terminate
with below error:

--- FAIL: TestCreateServiceMultipleTimes (24.11s)
daemon.go:285: [ddc3c7c1476c2] waiting for daemon to start
daemon.go:317: [ddc3c7c1476c2] daemon started
poll.go:121: timeout hit after 10s: task count at 4 waiting for 0
daemon.go:275: [ddc3c7c1476c2] exiting daemon
clean.go:108: Removing image sha256:e6a8d12d58602a19277ee5632b7ff9fa56a4ea52ba00eedf1d3f6f5a495fe761
clean.go:108: Removing image sha256:876244cc2ecb8fe1b0b2e817e3b78709a2a735edb093bc6849f99aa6c18f3a01

This PR adjusts the timeout value for both arm64 and arm to mitigate
this issue on those 2 platforms.

Signed-off-by: Dennis Chen [email protected]

- What I did
Fix a timeout issue which terminates the integration test
- How I did it
Adjust the timeout value
- How to verify it
make test-integration based on the latest codes.
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Now we only adjust the timeout value for `arm` while not `arm64`,
actually the avarage duration for this test is about 25s to crate
multiple services on arm64, else the integration test will terminate
with below error:

> --- FAIL: TestCreateServiceMultipleTimes (24.11s)
>         daemon.go:285: [ddc3c7c1476c2] waiting for daemon to start
>         daemon.go:317: [ddc3c7c1476c2] daemon started
>         poll.go:121: timeout hit after 10s: task count at 4 waiting for 0
>         daemon.go:275: [ddc3c7c1476c2] exiting daemon
>         clean.go:108: Removing image sha256:e6a8d12d58602a19277ee5632b7ff9fa56a4ea52ba00eedf1d3f6f5a495fe761
>         clean.go:108: Removing image sha256:876244cc2ecb8fe1b0b2e817e3b78709a2a735edb093bc6849f99aa6c18f3a01

This PR adjusts the timeout value for both `arm64` and `arm` to mitigate
this issue on those 2 platforms.

Signed-off-by: Dennis Chen <[email protected]>
Copy link
Copy Markdown
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

All green now 👍

@thaJeztah thaJeztah merged commit 86cb53e into moby:master Jan 13, 2018
@arm64b arm64b deleted the fix-timeout-multi-services branch February 13, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants