Fix race with concurrent daemon startup in tests#35982
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jan 11, 2018
Merged
Conversation
Using parallel tests is nice, however it can cause an issue with multiple daemons trying to make changes to iptables at the same time which causes flakey tests. This just disables iptables for the set of tests since it is not required. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
fix_concurrent_daemon_test_issues
branch
from
7dc1bda to
9e31938
Compare
Member
Author
|
Fixed typo in commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using parallel tests is nice, however it can cause an issue with
multiple daemons trying to make changes to iptables at the same time
which causes flakey tests.
This just disables iptables for the set of tests since it is not
required.
Fixes #35914