Windows: Bump RW layer size#35925
Merged
johnstep merged 1 commit intomoby:masterfrom Jan 5, 2018
Merged
Conversation
Signed-off-by: John Howard <[email protected]>
thaJeztah
added
impact/changelog
platform/windows
status/2-code-review
area/builder
|
Is this the first part of a fix for #33586 ? |
Member
Author
|
@mikebolland No, that is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
@johnstep @darrenstahlmsft As mentioned offline... PTAL
This bumps the size of the RW layer (sandbox.vhdx) from the default (20GB, hard coded in the platform) to 127GB (purely as the default size of a VHD in Hyper-V) for the builder RUN scenario where users are adding a lot of data during a RUN statement (eg while debugging #32838). Done local verification using diskmgmt.msc watching disk being attached/detached to verify it's operating as expected.
It does not change the default size for a
docker run(which can be controlled anyway through--storage-opt)@friism FYI.