Fix event filter filtering on "or" #35896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event filter used two separate filter-conditions for "namespace" and "topic". As a result, both events matching "topic" and events matching "namespace" were subscribed to, causing events to be handled both by the "plugin" client, and "container" client. This patch rewrites the filter to match only if both namespace and topic match. Thanks to Stephen Day for providing the correct filter :) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was referenced Dec 29, 2017
|
LGTM |
|
|
|
LGTM |
300min is already way too long to wait for tests. We shouldn't need to re-run every test on every platform. I think we need to be looking for tests that can be skipped on z instead of increasing any timeouts. |
banuchka
added a commit
to banuchka/docker-ce
that referenced
this pull request
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #35891
The event filter used two separate filter-conditions for "namespace" and "topic". As a result, both events matching "topic" and events matching "namespace" were subscribed to, causing events to be handled both by the "plugin" client, and "container" client.
This patch rewrites the filter to match only if both namespace and topic match.
Thanks to Stephen Day for providing the correct filter :)
- Description for the changelog