Legacy images replacement with multi-arch ones on AArch64 #35773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace those legacy docker images prefixed by 'aarch64/' and 'arm64v8/' with official multi-arch ones. Signed-off-by: Dennis Chen <[email protected]>
estesp
approved these changes
Dec 12, 2017
Contributor
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; not sure our rebuild/arm tag is 64-bit ARM? So, not clear to me we have any way to test, but I'm guessing this is definitely the right change for those who are doing arm64 :)
Contributor
|
LGTM |
Contributor
Author
|
@estesp I guess you're talking about the CI system 😄 Seems there's no arm64 servers for the CI testing, if you guys want to deploy one on AArch64 platform, maybe I can be help. It will be free, totally 🎃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace those legacy docker images prefixed by 'aarch64/' and 'arm64v8/'
with official multi-arch ones.
Signed-off-by: Dennis Chen [email protected]
- What I did
Replace the legacy docker images with the multi-arch ones on AArch64 platforms.
- How I did it
Use the official multi-arch images from the docker hub replace its legacy counterparts
- How to verify it
After apply the patch,
make binary&make test-integrationupon both legacy and multi-arch docker images, on both arm64 and amd64 platforms.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
