Fix consumes MIME type for NetworkConnect#35542
Merged
Merged
Conversation
This route expects `application/json`. Sending a content type header of `application/octet-stream` results in an error. Signed-off-by: Asad Saeeduddin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Changed the MIME type of the NetworkConnect route to the correct type.
- How I did it
The route expects
application/jsoninstead ofapplication/octet-stream. This can be seen from the schema of thebodyparameter as well as from actually calling the route (it explodes if sent anapplication/octet-streamcontent type header).- How to verify it
Try calling the route with the old and new MIME types for the
Content-Typeheader. Only the new one will work.- Description for the changelog
Changed the MIME type of the NetworkConnect route to the correct type.
- A picture of a cute animal (not mandatory but encouraged)
