Added SubSecondPrecision to config option. by imumesh18 · Pull Request #35529 · moby/moby

imumesh18 · 2017-11-16T18:19:56Z

Fixes issue #35384 .

imumesh18 · 2017-11-19T16:55:24Z

Hi, Can anyone please review my PR.

cc @ripcurld0 @thaJeztah

boaz0

LGTM 💯
Can you squash your commits into one, though? 😃

imumesh18 · 2017-11-20T06:57:57Z

Hey @ripcurld0 done that. 😃 . Anything else you want me change let me know.

imumesh18 · 2017-11-27T12:05:14Z

Requesting review @cpuguy83 @dnephin @anusha-ragunathan

thaJeztah · 2017-11-28T19:46:06Z

Wondering if this should take a similar approach as --syslog-format to specify the time-format to be used;

imumesh18 · 2017-11-30T12:38:20Z

I haven't given a thought to that @thaJeztah . As the issue was just to add subsecond to fluentd, so I did that. I have to see about this because I am completely new and also a noob. So I will let you know once I have something regarding this.

anusha-ragunathan · 2017-11-30T17:19:26Z

I'm fine with this change.

Needs doc updates in https://github.com/docker/docker.github.io/blob/8896e88867202a2dda926adadb6a4a350fd10165/engine/admin/logging/fluentd.md#options and auto completion updates for bash and zsh.

imumesh18 · 2017-11-30T17:25:04Z

For docs I will create an pull by tomorrow. But I didn't get the auto completion updates for bash and zsh. Can you explain it to me? Thanks!

anusha-ragunathan · 2017-11-30T17:29:27Z

When a new command/option is added to docker cli, we also add it to auto completion for user's convenience.
https://github.com/docker/cli/blob/b45a49c83fc4a79b1f5de343d48e5b8d27bc72e5/contrib/completion/bash/docker#L838 & https://github.com/docker/cli/blob/5e2be6584acd57eafe23d17f61f9bef1c521bf21/contrib/completion/zsh/_docker#L229

imumesh18 · 2017-11-30T17:33:54Z

Sure I will have a look into it and I will try create a PR for that as well by this weekend. Thanks for your time and review. 😄

imumesh18 · 2017-12-01T13:51:20Z

Hey @anusha-ragunathan . I have added documentation and auto completion command for bash and zsh. Here are those PR:

anusha-ragunathan · 2017-12-01T20:07:13Z

LGTM

thaJeztah · 2017-12-01T21:37:05Z

ping @tagomoris are there plans to tag a new release? (diff since last release: fluent/fluent-logger-golang@v1.2.1...master)

Oh, I missed it. Will do it in this week.

Hey @tagomoris , Please ping me once you have added a tag to it so that I can do the changes here.

@dungeonmaster18 done!

thaJeztah · 2017-12-01T21:43:15Z

We can probably update this dependency as well; philhofer/fwd@98c11a7...master (not needed in this PR)

But there is no release tag. Just seen that. But I have asked the developer to add a release tag let's c if I get an reply.

Yes, we can do in a follow up; generally tags would be preferred, but we don't strictly enforce them (for the github.com/fluent/fluent-logger-golang, I knew @tagomoris could help out quickly, so 😇 )

GordonTheTurtle · 2017-12-05T11:25:08Z

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "subsecond-precision-config" [email protected]:dungeonmaster18/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: dungeonmaster18 <[email protected]>

cpuguy83

LGTM

Would be really awesome if someone could follow-up to add the WriteTimeout support which is new in flutend-golang as well.

imumesh18 · 2017-12-05T17:05:37Z

I will check that @cpuguy83 and I will also ask people behind msgpack and philhofer/fwd to add tags to their package so that we can replace the commit id from vendor.conf. I will create a pull for that once I am done with that.

thaJeztah

LGTM, thanks!

GordonTheTurtle added dco/no Automatically set by a bot when one of the commits lacks proper signature status/0-triage and removed dco/no Automatically set by a bot when one of the commits lacks proper signature labels Nov 16, 2017

boaz0 approved these changes Nov 20, 2017

View reviewed changes

boaz0 added status/2-code-review and removed status/0-triage labels Nov 20, 2017

moby deleted a comment from GordonTheTurtle Nov 29, 2017

GordonTheTurtle assigned LK4D4 Dec 1, 2017

This was referenced Dec 1, 2017

Add autocomplete for fluentd-sub-second-precision flag in bash and zsh. docker/cli#723

Closed

Add documentation for fluentd-sub-second-precision flag in fluentd plugin docs. docker/docs#5425

Closed

thaJeztah reviewed Dec 1, 2017

View reviewed changes

joaofnfernandes mentioned this pull request Dec 4, 2017

[17.12] Added documentation for fluentd plugin sub-second-precision flag. docker/docs#5428

Closed

thaJeztah reviewed Dec 5, 2017

View reviewed changes

imumesh18 mentioned this pull request Dec 5, 2017

Closes #35384 Add support for SubSecondPrecision flag in fluentd logger #35538

Closed

GordonTheTurtle added the dco/no Automatically set by a bot when one of the commits lacks proper signature label Dec 5, 2017

GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Dec 5, 2017

Added SubSecondPrecision flag in fluentd logger

a1ebda0

Signed-off-by: dungeonmaster18 <[email protected]>

cpuguy83 added the rebuild/powerpc label Dec 5, 2017

GordonTheTurtle removed the rebuild/powerpc label Dec 5, 2017

cpuguy83 approved these changes Dec 5, 2017

View reviewed changes

cpuguy83 added status/4-merge and removed status/2-code-review labels Dec 5, 2017

thaJeztah approved these changes Dec 5, 2017

View reviewed changes

thaJeztah added impact/changelog impact/cli impact/documentation labels Dec 5, 2017

thaJeztah merged commit 3461289 into moby:master Dec 5, 2017

thaJeztah mentioned this pull request Dec 5, 2017

Added auto complete command for fluentd-sub-second-precision. docker/cli#724

Merged

imumesh18 deleted the subsecond-precision-config branch December 5, 2017 18:35

imumesh18 mentioned this pull request Dec 6, 2017

Expose SubSecondPrecision config option for fluentd logging driver #35384

Closed

thaJeztah added the area/logging label Dec 11, 2017

Conversation

imumesh18 commented Nov 16, 2017

Uh oh!

imumesh18 commented Nov 19, 2017

Uh oh!

boaz0 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imumesh18 commented Nov 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

imumesh18 commented Nov 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Nov 28, 2017

Uh oh!

imumesh18 commented Nov 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anusha-ragunathan commented Nov 30, 2017

Uh oh!

imumesh18 commented Nov 30, 2017

Uh oh!

anusha-ragunathan commented Nov 30, 2017

Uh oh!

imumesh18 commented Nov 30, 2017

Uh oh!

imumesh18 commented Dec 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anusha-ragunathan commented Dec 1, 2017

Uh oh!

thaJeztah Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

tagomoris Dec 4, 2017

Choose a reason for hiding this comment

Uh oh!

imumesh18 Dec 4, 2017

Choose a reason for hiding this comment

Uh oh!

tagomoris Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

thaJeztah Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

imumesh18 Dec 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thaJeztah Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

GordonTheTurtle commented Dec 5, 2017

Uh oh!

cpuguy83 left a comment

Choose a reason for hiding this comment

Uh oh!

imumesh18 commented Dec 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

boaz0 left a comment •

edited

Loading

imumesh18 commented Nov 20, 2017 •

edited

Loading

imumesh18 commented Nov 27, 2017 •

edited

Loading

imumesh18 commented Nov 30, 2017 •

edited

Loading

imumesh18 commented Dec 1, 2017 •

edited

Loading

imumesh18 Dec 5, 2017 •

edited

Loading

imumesh18 commented Dec 5, 2017 •

edited

Loading