Split and remove pkg/stringutils#35473
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 13, 2017
Merged
Conversation
Signed-off-by: Chao Wang <[email protected]>
Member
|
oh, oops, saw you requested a review from @vdemeester as well; let me know if I merged too soon 😅 |
Contributor
Author
|
@thaJeztah @dnephin You are welcome. If there's sth else that I 🐖 can help, plz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chao Wang [email protected]
- What I did
Split the package first, see tasklist at #35313 and remove it safely now.
- How I did it
According to @thaJeztah 's suggestion at #35034(closed)
And maybe it should be added to the tasklist at Find a place for /pkg #32989 @dnephin