Remove solaris build tag and contrib/mkimage/solaris#35373
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Nov 2, 2017
Merged
Remove solaris build tag and contrib/mkimage/solaris#35373AkihiroSuda merged 1 commit intomoby:masterfrom
contrib/mkimage/solaris#35373AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
requested changes
Nov 1, 2017
Member
There was a problem hiding this comment.
this file should probably be renamed to _linux.go then the build-tag can be removed
Member
Author
There was a problem hiding this comment.
Thanks that works! Updated.
libcontainerd/remote_daemon_unix.go
Outdated
Signed-off-by: Yong Tang <[email protected]>
yongtang
force-pushed
the
11012017-solaris
branch
from
47057b3 to
4785f1a
Compare
kolyshkin
pushed a commit
that referenced
this pull request
Sep 2, 2019
Support for GOOS=solaris was removed in PR #35373. Remove two leftover *_solaris.go files missed in this PR. Signed-off-by: Tobias Klauser <[email protected]>
burnMyDread
pushed a commit
to burnMyDread/moby
that referenced
this pull request
Oct 21, 2019
Support for GOOS=solaris was removed in PR moby#35373. Remove two leftover *_solaris.go files missed in this PR. Signed-off-by: Tobias Klauser <[email protected]> Signed-off-by: zach <[email protected]>
cipherboy
added a commit
to cipherboy/openbao
that referenced
this pull request
Nov 14, 2024
Solaris has no support in upstream Moby any more; while we currently only test with Docker, we may wish to support containerized plugins running on remote hosts in the future and would be unable to do so from Solaris. Additionally, this release target sees few downloads and thus isn't worth maintainer time to support. See also: moby/moby#35373 See also: https://tooomm.github.io/github-release-stats/?username=openbao&repository=openbao Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
to cipherboy/openbao
that referenced
this pull request
Nov 14, 2024
Solaris has no support in upstream Moby any more; while we currently only test with Docker, we may wish to support containerized plugins running on remote hosts in the future and would be unable to do so from Solaris. Additionally, this release target sees few downloads and thus isn't worth maintainer time to support. See also: moby/moby#35373 See also: https://tooomm.github.io/github-release-stats/?username=openbao&repository=openbao Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
to openbao/openbao
that referenced
this pull request
Nov 14, 2024
* Fully upgrade Docker dependency This follows churn caused by Docker removing type aliases in use by others. See also: moby/moby#47148 Signed-off-by: Alexander Scheel <[email protected]> * Remove support for Solaris builds Solaris has no support in upstream Moby any more; while we currently only test with Docker, we may wish to support containerized plugins running on remote hosts in the future and would be unable to do so from Solaris. Additionally, this release target sees few downloads and thus isn't worth maintainer time to support. See also: moby/moby#35373 See also: https://tooomm.github.io/github-release-stats/?username=openbao&repository=openbao Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> --------- Signed-off-by: Alexander Scheel <[email protected]>
Nerkho
pushed a commit
to Nerkho/openbao
that referenced
this pull request
Feb 26, 2025
* Fully upgrade Docker dependency This follows churn caused by Docker removing type aliases in use by others. See also: moby/moby#47148 Signed-off-by: Alexander Scheel <[email protected]> * Remove support for Solaris builds Solaris has no support in upstream Moby any more; while we currently only test with Docker, we may wish to support containerized plugins running on remote hosts in the future and would be unable to do so from Solaris. Additionally, this release target sees few downloads and thus isn't worth maintainer time to support. See also: moby/moby#35373 See also: https://tooomm.github.io/github-release-stats/?username=openbao&repository=openbao Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> --------- Signed-off-by: Alexander Scheel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Solaris is not really supported any more. I am proposing to remove the build tags and other reference to Solaris from the code base.
This fix cleaned all traces of solaris in build tags and files.
Signed-off-by: Yong Tang [email protected]