Skip to content

Add windows CI entry point script to repo#35362

Closed
dnephin wants to merge 2 commits intomoby:masterfrom
dnephin:fix-windows-ci-entrypoint
Closed

Add windows CI entry point script to repo#35362
dnephin wants to merge 2 commits intomoby:masterfrom
dnephin:fix-windows-ci-entrypoint

Conversation

@dnephin
Copy link
Member

@dnephin dnephin commented Nov 1, 2017

This change is a requirement for #34226.

This change also brings the windowsRS1 build in line with all the other builds, which have an entry point at hack/ci. The windowsRS1 config has been updated to call this script.

This change is important because currently the configuration in jenkins makes too many assumptions about the repo and artifacts created by the build. We need a minimal interface between our CI configuration and the repo, so that we are free to make changes in a PR without requiring complicated acrobatics to support those changes in CI.

cc @johnstep @jhowardmsft @tiborvass

@dnephin dnephin requested a review from tianon as a code owner November 1, 2017 16:26
@dnephin dnephin force-pushed the fix-windows-ci-entrypoint branch from fcdca47 to f671ada Compare November 1, 2017 16:31
@dnephin dnephin mentioned this pull request Nov 1, 2017
Closed
@cpuguy83 cpuguy83 requested review from johnstep and lowenna November 1, 2017 17:39
@cpuguy83
Copy link
Member

cpuguy83 commented Nov 1, 2017

SGTM

@dnephin
Copy link
Member Author

dnephin commented Jan 2, 2018

ping

johnstep
johnstep approved these changes Jan 3, 2018
View reviewed changes
Copy link
Member

@johnstep johnstep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Jan 8, 2018

ping @jhowardmsft PTAL

@lowenna
Copy link
Member

lowenna commented Mar 22, 2018

Can this be named windowsRS without the number? It's the same script used for RS3/4 (although they're not live). Also, @seemethere uses a forked/modified script for the CE RS1 which never got merged back into the jhowardmsft/docker-w2w-ciscripts repo, so this won't work for that context.

@thaJeztah
Copy link
Member

thaJeztah commented Mar 22, 2018

Asked @seemethere on Slack to have a look

@seemethere
Copy link
Contributor

seemethere commented Mar 22, 2018

@thaJeztah The only thing we really need for this to work for Docker CE/EE specific testing is a way to pass a CLI binary in, for everything else I can write a wrapper script for our internal CI.

@dnephin
Copy link
Member Author

dnephin commented Mar 26, 2018

Can this be named windowsRS without the number?

The script filename should match the jenkins build. If there are parts of this that can be shared then maybe it can be refactored.

@lowenna
Copy link
Member

lowenna commented Mar 26, 2018

It's identical for all RS builds so far (1..5). Hence it should just be "RS" without the moniker

@vdemeester vdemeester mentioned this pull request Apr 5, 2018
Closed
@salah-khan salah-khan mentioned this pull request Aug 24, 2018
Merged
@thaJeztah thaJeztah mentioned this pull request Oct 11, 2018
Merged
@andrewhsu
Copy link
Contributor

andrewhsu commented Sep 18, 2019

Looks like this PR should be closed because PR #37715 already brought in hack/ci/windowsRS1.ps1.

@cpuguy83 cpuguy83 closed this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon Awaiting requested review from tianon tianon is a code owner

@lowenna lowenna Awaiting requested review from lowenna

1 more reviewer

@johnstep johnstep johnstep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yongtang yongtang

Labels

area/testing platform/windows status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@dnephin @cpuguy83 @thaJeztah @lowenna @seemethere @andrewhsu @johnstep @yongtang @GordonTheTurtle